Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): enable tests in bigtable-stats for native image compilation #1308

Closed
wants to merge 2 commits into from

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Jul 12, 2022

The native image tests are currently failing with the following error: Test configuration file wasn't found. Make sure that test execution wasn't skipped which occurs when the native-maven-plugin can't find tests to run with native image compilation. Naming the tests following this convention allows them to be enabled for native image testing.

This PR precedes #1288

cc @suztomo

@mpeddada1 mpeddada1 requested a review from igorbernstein2 July 12, 2022 17:11
@mpeddada1 mpeddada1 requested a review from a team as a code owner July 12, 2022 17:11
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jul 12, 2022
@mpeddada1 mpeddada1 changed the title fix(java) enable tests in bigtable-stats for native image compilation fix(java): enable tests in bigtable-stats for native image compilation Jul 12, 2022
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2022
@igorbernstein2 igorbernstein2 requested review from mutianf and removed request for igorbernstein2 July 14, 2022 14:38
@mpeddada1
Copy link
Contributor Author

An observation: the native images tests are now passing with these tests being included. However, Kokoro - Integration is resulting in the following error:

java.lang.ClassCastException: com.google.bigtable.veneer.repackaged.io.opencensus.stats.AutoValue_View cannot be cast to io.opencensus.stats.View
	at com.google.cloud.bigtable.stats.ITBuiltinViewConstantsTest.testBasicTagsExistForAllViews(ITBuiltinViewConstantsTest.java:26)

Perhaps these tests are not meant to be run as integration tests at the moment.

@mpeddada1
Copy link
Contributor Author

Closing this PR in favor of #1311

@mpeddada1 mpeddada1 closed this Jul 15, 2022
@mpeddada1 mpeddada1 deleted the enable-native-image branch July 15, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants