Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add paging to hbase client #4166
fix: Add paging to hbase client #4166
Changes from 70 commits
ef49c26
f5710b2
ecd88f9
88373d0
2144a6f
63c7492
40e5759
6d15df1
5254712
d1dc685
424f453
8a0d1f5
0f14715
22ae1fc
84be8a0
dc6a9dc
b8d05d3
5b99b77
435bb73
e4f34fc
b539bb5
34f00d1
a944e6b
244bbb7
a1e3d54
2aa5d17
0093a78
1667188
f394ba2
d1ef3b6
423df71
3d9f18c
fdf511b
fd15972
2a3b125
a93d3bb
55af2e0
52425f1
cced23a
06b8b2e
b50ec9f
6535e6c
d025473
1e61132
9df66fe
cdf7347
951ebef
7ba3c64
d4ed8e5
d4bede1
06227d2
947608a
e23101c
4e15493
56bb3f1
34653ed
a082a9e
871d66b
06ce458
a95e218
03c0e3b
b5fdeeb
b0c7cbf
262525f
7382aa9
5b510a1
80ffea0
da22f6e
7dd6b49
40545c1
fb86765
91ee89e
c91d6f9
410d203
ce514ee
bf23528
a819985
a6738f5
52d8a12
ab65b95
1fc9369
048ca63
e72dca0
f6132ba
a519462
96e49fb
8bccc3c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I should be more clear on my previous comment. I think we want to test both getScanner without pagination and getScanner with pagiation. So maybe we can add a parameter:
testManyResultsInScanner(int rowsToWrite, boolean with pagination);
And add one more test: testManyResultsInScanner(100, false);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can pass in the default to begin with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's private, and I wouldn't want to expose it. This value is just for tests, so I don't think it's critical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could move the default value in this class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you defer the creation of the ScanCallContext? The effect of re-creating it is that you are extending the operation timeout across all of the pages. I think the operation deadline should stay consistent from the callers perspective regardless if its broken up into multiple segments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert irrelevant changes to minimize the noise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be in the if statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done