Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating emulator test to use the wrapper #2078

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Updating emulator test to use the wrapper #2078

merged 1 commit into from
Feb 6, 2019

Conversation

sduskis
Copy link
Contributor

@sduskis sduskis commented Feb 6, 2019

FYI, the code is so much nicer with the new model.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2019
igorbernstein2
igorbernstein2 approved these changes Feb 6, 2019
View reviewed changes
Copy link
Collaborator

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sduskis sduskis merged commit 2ea2560 into googleapis:master Feb 6, 2019
@sduskis sduskis deleted the update_emulator_test branch February 6, 2019 23:21
@sduskis sduskis mentioned this pull request Feb 7, 2019
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sduskis @igorbernstein2 @googlebot