BigtableOptionsFactory.fromConfiguration doesn't respect emulator credential settings

[precupqdm]

I was attempting to use the google.bigtable.emulator.endpoint.host configuration option when I noticed I still needed application default credentials set up anyways. A quick debug shows that in BigtableOptionsFactory.fromConfiguration it configures the emulator settings, including enabling null credentials, and then overwrites them in the call to setChannelOptions later on in the function.

It does work if I set the following two options as well:

conf.set(BigtableOptionsFactory.BIGTABLE_NULL_CREDENTIAL_ENABLE_KEY, "true");
conf.set(BigtableOptionsFactory.BIGTABLE_USE_SERVICE_ACCOUNTS_KEY, "false");

If the intent was to need all three feel free to close and I'll be on my way, but it seemed unlikely given that the enableEmulator function sets them up.

[sduskis]

Woops. We're looking at this.

[sduskis]

This should be fixed by #1948

[precupqdm]

Thanks for getting this fixed so quickly!