Skip to content

Commit

Permalink
chore(main): release 2.12.1
Browse files Browse the repository at this point in the history
  • Loading branch information
release-please[bot] authored Mar 28, 2024
1 parent 73fff5a commit e044a38
Show file tree
Hide file tree
Showing 53 changed files with 183 additions and 150 deletions.
33 changes: 33 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,38 @@
# Changelog

## [2.12.1](https://github.com/googleapis/java-bigtable-hbase/compare/v2.12.0...v2.12.1) (2024-03-28)


### Bug Fixes

* Retry idle timeout ([#4209](https://github.com/googleapis/java-bigtable-hbase/issues/4209)) ([4064af8](https://github.com/googleapis/java-bigtable-hbase/commit/4064af8968d58f4328807b0f02423df8ead2a292))


### Dependencies

* Add a direct dep on google-cloud-bigtable in the -shaded artifacts to workaround UpperBound issues ([#4244](https://github.com/googleapis/java-bigtable-hbase/issues/4244)) ([15c567a](https://github.com/googleapis/java-bigtable-hbase/commit/15c567ae56a9f10a0f8ffc104ff848e9014d2a10))
* Clean up deps for mirroring-client ([#4232](https://github.com/googleapis/java-bigtable-hbase/issues/4232)) ([5f98419](https://github.com/googleapis/java-bigtable-hbase/commit/5f984191e211ad8f721ff4e63d76d793c6ce1224))
* Clean up deps in replication client ([#4235](https://github.com/googleapis/java-bigtable-hbase/issues/4235)) ([a27ca11](https://github.com/googleapis/java-bigtable-hbase/commit/a27ca111d60feebeb36870d038d99c613552da94))
* Clean up mirroring client deps ([#4261](https://github.com/googleapis/java-bigtable-hbase/issues/4261)) ([ce9e53b](https://github.com/googleapis/java-bigtable-hbase/commit/ce9e53bc8402cd7db8dcaf574a4160583c7bb3b3))
* Make dropwizard metrics an optional dependency ([#4224](https://github.com/googleapis/java-bigtable-hbase/issues/4224)) ([afb1802](https://github.com/googleapis/java-bigtable-hbase/commit/afb1802d920b8e4ab035630c563965bfd7efaa8b))
* Mark conscrypt as a provided dep ([#4200](https://github.com/googleapis/java-bigtable-hbase/issues/4200)) ([62ed2d0](https://github.com/googleapis/java-bigtable-hbase/commit/62ed2d0114df7171fffb029e8d969ef4bc00848d))
* Minor tweaks ([#4241](https://github.com/googleapis/java-bigtable-hbase/issues/4241)) ([ff97ac9](https://github.com/googleapis/java-bigtable-hbase/commit/ff97ac926c00aa3c09f4ed9ceba6a017d898e695))
* Remove overspecified slf4 versions & remove unused props ([#4240](https://github.com/googleapis/java-bigtable-hbase/issues/4240)) ([fff9ff0](https://github.com/googleapis/java-bigtable-hbase/commit/fff9ff03d84337d67ab857709d8d24dde75ecaf8))
* Unflatten 2x hadoop & shaded artifact deps ([#4226](https://github.com/googleapis/java-bigtable-hbase/issues/4226)) ([d32e540](https://github.com/googleapis/java-bigtable-hbase/commit/d32e54047c054562df0c0a22a12c64e81549aa3b))
* Unflatten build-helper module ([#4229](https://github.com/googleapis/java-bigtable-hbase/issues/4229)) ([0a7d88a](https://github.com/googleapis/java-bigtable-hbase/commit/0a7d88a27efbd1a3fafea97eea06b9cb82286b64))
* Unflatten dataflow artifact deps ([#4228](https://github.com/googleapis/java-bigtable-hbase/issues/4228)) ([9ff8df2](https://github.com/googleapis/java-bigtable-hbase/commit/9ff8df23e0c3921d47d9e1b04b951c022fc50267))
* Unflatten deps for 1x shaded and hadoop ([#4223](https://github.com/googleapis/java-bigtable-hbase/issues/4223)) ([df0a821](https://github.com/googleapis/java-bigtable-hbase/commit/df0a8219b20e63d88e23e6aa852eed0f2f1dd277))
* Unflatten deps for bigtable-hbase-1.x ([#4222](https://github.com/googleapis/java-bigtable-hbase/issues/4222)) ([194d061](https://github.com/googleapis/java-bigtable-hbase/commit/194d061dba49df125b2818e64bce85a8a67df7ad))
* Unflatten deps for hbase 2x ([#4239](https://github.com/googleapis/java-bigtable-hbase/issues/4239)) ([8795de8](https://github.com/googleapis/java-bigtable-hbase/commit/8795de83e3bab65f1cc1704a52b1fbd53efd97a0))
* Unflatten the rest of the 1x artifacts ([#4227](https://github.com/googleapis/java-bigtable-hbase/issues/4227)) ([5778ecb](https://github.com/googleapis/java-bigtable-hbase/commit/5778ecb5fda39533056d0fc266389ee70d73d04c))
* Unflatten transitive dependencies in integration-tests-common ([#4208](https://github.com/googleapis/java-bigtable-hbase/issues/4208)) ([9321f8b](https://github.com/googleapis/java-bigtable-hbase/commit/9321f8b82dd5159d2e95f2cc301ca4e5a1585b2f))
* Unflatten transitive dependencies in bigtable-hbase ([#4207](https://github.com/googleapis/java-bigtable-hbase/issues/4207)) ([ee15b1c](https://github.com/googleapis/java-bigtable-hbase/commit/ee15b1c129be5a8bd089fcc9e09f41e95c7dfdc3))
* Update bigtable-metrics-api version ([#4193](https://github.com/googleapis/java-bigtable-hbase/issues/4193)) ([000208c](https://github.com/googleapis/java-bigtable-hbase/commit/000208c32e7318f0d89e7b34da315d6ad098a13b))
* Update dependency io.dropwizard.metrics:metrics-graphite to v4.2.22 ([#4230](https://github.com/googleapis/java-bigtable-hbase/issues/4230)) ([68024f8](https://github.com/googleapis/java-bigtable-hbase/commit/68024f8a24ae54b8692e27c4993772548e51a78d))
* Update dependency net.bytebuddy:byte-buddy to v1.14.10 ([#4250](https://github.com/googleapis/java-bigtable-hbase/issues/4250)) ([cff9ada](https://github.com/googleapis/java-bigtable-hbase/commit/cff9ada517b42b6c36cb297286cb8e442f2378fc))
* Update to beam 2.51.0 ([#4204](https://github.com/googleapis/java-bigtable-hbase/issues/4204)) ([c17306c](https://github.com/googleapis/java-bigtable-hbase/commit/c17306c64519297526bf619f60eabaf24776b9e6))
* Upgrade google-cloud-java to 2.29.1 ([#4245](https://github.com/googleapis/java-bigtable-hbase/issues/4245)) ([9a5e116](https://github.com/googleapis/java-bigtable-hbase/commit/9a5e1166089a0229f6b29938966cc48d3497af2d))

## [2.12.0](https://github.com/googleapis/java-bigtable-hbase/compare/v2.11.3...v2.12.0) (2023-10-18)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ limitations under the License.
<parent>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-client-core-parent</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
</parent>

<artifactId>bigtable-hbase-integration-tests-common</artifactId>
Expand Down
6 changes: 3 additions & 3 deletions bigtable-client-core-parent/bigtable-hbase/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ limitations under the License.
<parent>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-client-core-parent</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
</parent>

<artifactId>bigtable-hbase</artifactId>
Expand Down Expand Up @@ -85,7 +85,7 @@ limitations under the License.
<dependency>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-internal-test-helper</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<scope>test</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -149,7 +149,7 @@ limitations under the License.
<plugin>
<groupId>com.google.cloud.bigtable.test</groupId>
<artifactId>bigtable-build-helper</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->

<executions>
<execution>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class BigtableHBaseVersion {
private static final AtomicBoolean wasInitialized = new AtomicBoolean(false);

// {x-version-update-start:bigtable-client-parent:current}
public static final String VERSION = "2.12.1-SNAPSHOT";
public static final String VERSION = "2.12.1";
// {x-version-update-end}

/**
Expand Down
2 changes: 1 addition & 1 deletion bigtable-client-core-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ limitations under the License.
<parent>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-client-parent</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
</parent>

<artifactId>bigtable-client-core-parent</artifactId>
Expand Down
8 changes: 4 additions & 4 deletions bigtable-dataflow-parent/bigtable-beam-import/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ limitations under the License.
<parent>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-dataflow-parent</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down Expand Up @@ -85,7 +85,7 @@ limitations under the License.
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>bigtable-hbase-beam</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<exclusions>
<exclusion>
<groupId>org.apache.hbase</groupId>
Expand Down Expand Up @@ -141,7 +141,7 @@ limitations under the License.
<dependency>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-internal-test-helper</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<scope>test</scope>
</dependency>

Expand Down Expand Up @@ -325,7 +325,7 @@ limitations under the License.
<plugin>
<groupId>com.google.cloud.bigtable.test</groupId>
<artifactId>bigtable-build-helper</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<executions>
<!-- We are using beam's bom, so no need to check if the beam deps are mirrored -->
<execution>
Expand Down
6 changes: 3 additions & 3 deletions bigtable-dataflow-parent/bigtable-hbase-beam/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ limitations under the License.
<parent>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-dataflow-parent</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
</parent>

<artifactId>bigtable-hbase-beam</artifactId>
Expand Down Expand Up @@ -58,7 +58,7 @@ limitations under the License.
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>bigtable-hbase-1.x-shaded</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<exclusions>
<!-- Workaround MNG-5899 & MSHADE-206. Maven >= 3.3.0 doesn't use the dependency reduced
pom.xml files when invoking the build from a parent project. So we have to manually exclude
Expand Down Expand Up @@ -227,7 +227,7 @@ limitations under the License.
<plugin>
<groupId>com.google.cloud.bigtable.test</groupId>
<artifactId>bigtable-build-helper</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<executions>
<execution>
<id>verify-mirror-deps-beam</id>
Expand Down
2 changes: 1 addition & 1 deletion bigtable-dataflow-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ limitations under the License.
<parent>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-client-parent</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
</parent>

<artifactId>bigtable-dataflow-parent</artifactId>
Expand Down
6 changes: 3 additions & 3 deletions bigtable-hbase-1.x-parent/bigtable-hbase-1.x-hadoop/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ limitations under the License.
<parent>
<artifactId>bigtable-hbase-1.x-parent</artifactId>
<groupId>com.google.cloud.bigtable</groupId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
</parent>
<modelVersion>4.0.0</modelVersion>

Expand All @@ -34,7 +34,7 @@ limitations under the License.
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>bigtable-hbase-1.x-shaded</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<exclusions>
<!-- hbase-shaded-client will be replaced with hbase-client -->
<exclusion>
Expand Down Expand Up @@ -169,7 +169,7 @@ limitations under the License.
<plugin>
<groupId>com.google.cloud.bigtable.test</groupId>
<artifactId>bigtable-build-helper</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->

<executions>
<execution>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ limitations under the License.
<parent>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-hbase-1.x-parent</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
</parent>

<artifactId>bigtable-hbase-1.x-integration-tests</artifactId>
Expand Down Expand Up @@ -79,7 +79,7 @@ limitations under the License.
<dependency>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-hbase-1.x</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<exclusions>
<exclusion>
<groupId>org.apache.hbase</groupId>
Expand Down Expand Up @@ -117,7 +117,7 @@ limitations under the License.
<dependency>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-hbase-1.x-shaded</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<exclusions>
<exclusion>
<groupId>org.apache.hbase</groupId>
Expand Down Expand Up @@ -286,7 +286,7 @@ limitations under the License.
<dependency>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-hbase-1.x-shaded</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<exclusions>
<exclusion>
<groupId>org.apache.hbase</groupId>
Expand Down Expand Up @@ -467,7 +467,7 @@ limitations under the License.
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>bigtable-hbase-integration-tests-common</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<type>test-jar</type>
<scope>test</scope>
<exclusions>
Expand Down Expand Up @@ -580,7 +580,7 @@ limitations under the License.
<plugin>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>hbase-minicluster-maven-plugin</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->

<dependencies>
<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ limitations under the License.
<parent>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-hbase-1.x-parent</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
</parent>

<artifactId>bigtable-hbase-1.x-mapreduce</artifactId>
Expand Down Expand Up @@ -60,7 +60,7 @@ limitations under the License.
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>bigtable-hbase-1.x-hadoop</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<exclusions>
<!-- we need hbase-server instead of hbase-client -->
<exclusion>
Expand Down Expand Up @@ -120,7 +120,7 @@ limitations under the License.
<dependency>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-internal-test-helper</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<scope>test</scope>
</dependency>
</dependencies>
Expand Down Expand Up @@ -186,7 +186,7 @@ limitations under the License.
<plugin>
<groupId>com.google.cloud.bigtable.test</groupId>
<artifactId>bigtable-build-helper</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<executions>
<execution>
<id>verify-mirror-deps-hbase</id>
Expand Down
6 changes: 3 additions & 3 deletions bigtable-hbase-1.x-parent/bigtable-hbase-1.x-shaded/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ limitations under the License.
<parent>
<artifactId>bigtable-hbase-1.x-parent</artifactId>
<groupId>com.google.cloud.bigtable</groupId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down Expand Up @@ -107,7 +107,7 @@ limitations under the License.
<dependency>
<groupId>com.google.cloud.bigtable</groupId>
<artifactId>bigtable-hbase-1.x</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
</dependency>

<!-- This isnt strictly necessary as it will be pulled in by bigtable-hbase-1.x. However, it helps to resolve
Expand Down Expand Up @@ -348,7 +348,7 @@ limitations under the License.
<plugin>
<groupId>com.google.cloud.bigtable.test</groupId>
<artifactId>bigtable-build-helper</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->

<executions>
<execution>
Expand Down
4 changes: 2 additions & 2 deletions bigtable-hbase-1.x-parent/bigtable-hbase-1.x-tools/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<artifactId>bigtable-hbase-1.x-parent</artifactId>
<groupId>com.google.cloud.bigtable</groupId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
</parent>
<modelVersion>4.0.0</modelVersion>

Expand All @@ -23,7 +23,7 @@
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>bigtable-hbase-1.x-shaded</artifactId>
<version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<version>2.12.1</version> <!-- {x-version-update:bigtable-client-parent:current} -->
<exclusions>
<!-- Workaround MNG-5899 & MSHADE-206. Maven >= 3.3.0 doesn't use the dependency reduced
pom.xml files when invoking the build from a parent project. So we have to manually exclude
Expand Down
Loading

0 comments on commit e044a38

Please sign in to comment.