Skip to content

Commit

Permalink
Add dependency for google cloud java bigtable client and deprecate fi…
Browse files Browse the repository at this point in the history
…lters related class (#1917)

* Add java veneer client dependency and remove duplicate class

* Revert "Add java veneer client dependency and remove duplicate class"

This reverts commit f544a2a.

* Deprecate Filters related class instead of replace

* Use non shaded google java client dependancy.
  • Loading branch information
ajaaym authored and sduskis committed Sep 4, 2018
1 parent c23ee4b commit b0793ec
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 2 deletions.
10 changes: 10 additions & 0 deletions bigtable-client-core-parent/bigtable-client-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,16 @@ limitations under the License.
</dependencyManagement>

<dependencies>
<!-- Bigtable Java Veneer client -->
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-bigtable</artifactId>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-bigtable-admin</artifactId>
</dependency>

<!-- Protos -->
<dependency>
<groupId>com.google.api.grpc</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import java.io.IOException;
import java.io.OutputStream;

@InternalApi
@Deprecated @InternalApi
public final class RegexUtil {
private static final byte[] NULL_BYTES = "\\x00".getBytes();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
*
* }</pre>
*/
@InternalExtensionOnly
@Deprecated @InternalExtensionOnly
public final class Filters {
/** Entry point into the DSL. */
public static final Filters FILTERS = new Filters();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
* ByteStringRange r2 = r1.clone().endUnbounded();
* }</pre>
*/
@Deprecated
abstract class Range<T, R extends Range<T, R>> {
public enum BoundType {
OPEN,
Expand Down Expand Up @@ -150,6 +151,7 @@ private R thisT() {
}

/** Abstract specialization of a {@link Range} for timestamps. */
@Deprecated
abstract static class AbstractTimestampRange<R extends AbstractTimestampRange<R>>
extends Range<Long, R> implements Cloneable {
AbstractTimestampRange() {
Expand All @@ -175,6 +177,7 @@ protected R clone() {
* Abstract specialization of a {@link Range} for {@link ByteString}s. Allows for easy interop
* with simple Strings.
*/
@Deprecated
abstract static class AbstractByteStringRange<R extends AbstractByteStringRange<R>>
extends Range<ByteString, R> implements Cloneable {
AbstractByteStringRange() {
Expand Down Expand Up @@ -230,6 +233,7 @@ static ByteString wrap(String str) {
}

/** Concrete Range for timestamps */
@Deprecated
public static final class TimestampRange extends AbstractTimestampRange<TimestampRange> {
public static TimestampRange unbounded() {
return new TimestampRange(BoundType.UNBOUNDED, null, BoundType.UNBOUNDED, null);
Expand All @@ -245,6 +249,7 @@ private TimestampRange(BoundType startBound, Long start, BoundType endBound, Lon
}

/** Concrete Range for ByteStrings */
@Deprecated
public static final class ByteStringRange extends AbstractByteStringRange<ByteStringRange> {
public static ByteStringRange unbounded() {
return new ByteStringRange(BoundType.UNBOUNDED, null, BoundType.UNBOUNDED, null);
Expand Down

0 comments on commit b0793ec

Please sign in to comment.