feat: Add CivilTimeEncoder to encode and decode DateTime/Time as numerics

[JacobStocklass]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

[JacobStocklass]

Java LocalTime and LocalDateTime use Java 8 so will need to be reverted back to using Joda time so as not to change the language level.

[codecov]

Codecov Report

Merging #937 (317c773) into master (814c7dd) will decrease coverage by 0.28%.
The diff coverage is 77.52%.

❗ Current head 317c773 differs from pull request most recent head e25aee4. Consider uploading reports for the commit e25aee4 to get more accurate results

@@             Coverage Diff              @@
##             master     #937      +/-   ##
============================================
- Coverage     81.14%   80.86%   -0.29%     
- Complexity      996     1038      +42     
============================================
  Files            74       77       +3     
  Lines          5347     5645     +298     
  Branches        415      436      +21     
============================================
+ Hits           4339     4565     +226     
- Misses          838      897      +59     
- Partials        170      183      +13     

Impacted Files	Coverage Δ	Complexity Δ
...oud/bigquery/storage/v1beta2/CivilTimeEncoder.java	77.52% <77.52%> (ø)	18.00 <18.00> (?)
.../google/cloud/bigquery/storage/v1beta2/Waiter.java	56.04% <0.00%> (-16.90%)	12.00% <0.00%> (-6.00%)
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java	80.39% <0.00%> (-3.93%)	34.00% <0.00%> (-3.00%)
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java	82.33% <0.00%> (-2.70%)	32.00% <0.00%> (-6.00%)
...oud/bigquery/storage/v1beta2/JsonStreamWriter.java	76.52% <0.00%> (-2.47%)	14.00% <0.00%> (-1.00%)
...google/cloud/bigquery/storage/v1alpha2/Waiter.java	55.95% <0.00%> (-1.20%)	12.00% <0.00%> (-2.00%)
...bigquery/storage/v1/stub/GrpcBigQueryReadStub.java	89.53% <0.00%> (ø)	10.00% <0.00%> (ø%)
...ery/storage/v1beta2/stub/GrpcBigQueryReadStub.java	89.53% <0.00%> (ø)	10.00% <0.00%> (ø%)
...ry/storage/v1beta2/stub/GrpcBigQueryWriteStub.java	93.24% <0.00%> (ø)	15.00% <0.00%> (ø%)
...y/storage/v1alpha2/stub/GrpcBigQueryWriteStub.java	93.50% <0.00%> (ø)	15.00% <0.00%> (ø%)
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 814c7dd...e25aee4. Read the comment docs.

[stephaniewang526]

Not a feat, please rename (both subject and initial commit) this PR to test:

[JacobStocklass]

Not a feat, please rename (both subject and initial commit) this PR to test:

not sure how I misnamed this so badly. This should be adding in the feature CivilTimeEncoder, I will rename the subject and the initial commit, but should I still use test instead of feat?

[JacobStocklass]

@yirutang PTAL

[JacobStocklass]

@yirutang PTAL. I've removed the e2e test for another PR where we can change the mapping function as well.

[yirutang]

Almost there.

[yirutang]

I think you are missing a t at the end?

…

On Tue, Mar 16, 2021 at 10:08 AM JacobStocklass ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/CivilTimeEncoderTest.java <#937 (comment)> : > + // 0b000000000000000000000000000|01101|001110|001111|00000011111010000000 + // 0xD38F03E80 + assertEquals( + 0xD38F03E80L, + CivilTimeEncoder.encodePacked64TimeMicros(LocalTime.of(13, 14, 15, 16_000_000))); + // 23:59:59.999000 + // 0b000000000000000000000000000|10111|111011|111011|11110011111001011000 + // 0x17EFBF3E58 + assertEquals( + 0x17EFBF3E58L, + CivilTimeEncoder.encodePacked64TimeMicros(LocalTime.of(23, 59, 59, 999_000_000))); + } + + @test + public void encodePacked64TimeMicros_giveErrorWhenDataIsLos() { + I might change the name from DataLost to PrecisionLost — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#937 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHGYVEVXZWUOYLX6DCUPNV3TD6GA7ANCNFSM4ZBGWE7A> .

-- Thanks. Yiru

[yirutang]

Yeah, putting them together is easier to see.

…

On Tue, Mar 16, 2021 at 10:13 AM JacobStocklass ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/CivilTimeEncoderTest.java <#937 (comment)> : > +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; +import org.threeten.bp.LocalDateTime; +import org.threeten.bp.LocalTime; + ***@***.***(JUnit4.class) +public class CivilTimeEncoderTest { + private static final Logger LOG = Logger.getLogger(CivilTimeEncoderTest.class.getName()); + + // Time + @test + public void encodePacked64TimeMicros_validTime() { + // 00:00:00.000000 + // 0b000000000000000000000000000|00000|000000|000000|00000000000000000000 + // 0x0 + assertEquals(0x0L, CivilTimeEncoder.encodePacked64TimeMicros(LocalTime.of(0, 0, 0, 0))); I do have those cases in the decodePackd64TimeMicros_validBitFieldTimeMircros() test. Should they be combined into one test? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#937 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHGYVEQUQYB3RGK4IYRA3Y3TD6GVFANCNFSM4ZBGWE7A> .

-- Thanks. Yiru

[JacobStocklass]

@yirutang I've made the tweeks to the test code and I think it reads a bit easier now

[JacobStocklass]

@stephaniewang526 Hey Stephanie are you able to merge this PR? I believe it is ready