Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support inflight control in StreamWriterV2 #875

Merged
merged 9 commits into from
Feb 23, 2021
Merged

feat: Support inflight control in StreamWriterV2 #875

merged 9 commits into from
Feb 23, 2021

Conversation

yayi-google
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yayi-google yayi-google requested review from yirutang, bigang-li, a team and tswast February 23, 2021 19:40
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Feb 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 23, 2021
@yayi-google yayi-google removed the request for review from tswast February 23, 2021 19:40
@codecov
Copy link

codecov bot commented Feb 23, 2021 •
edited
Loading

Codecov Report

Merging #875 (74bb949) into master (0261af4) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #875      +/-   ##
============================================
- Coverage     80.67%   80.39%   -0.28%     
+ Complexity     1007      967      -40     
============================================
  Files            76       76              
  Lines          5438     5352      -86     
  Branches        421      396      -25     
============================================
- Hits           4387     4303      -84     
+ Misses          878      876       -2     
  Partials        173      173
Impacted Files Coverage Δ Complexity Δ
...cloud/bigquery/storage/v1beta2/StreamWriterV2.java 96.17% <100.00%> (+0.90%) 29.00 <5.00> (+4.00)
...bigquery/storage/v1alpha2/BigQueryWriteClient.java 77.61% <0.00%> (-2.91%) 28.00% <0.00%> (-10.00%)
...ery/storage/v1beta1/BaseBigQueryStorageClient.java 70.37% <0.00%> (-2.52%) 17.00% <0.00%> (-5.00%)
...ud/bigquery/storage/v1/BaseBigQueryReadClient.java 58.97% <0.00%> (-2.01%) 10.00% <0.00%> (-2.00%)
...gquery/storage/v1beta2/BaseBigQueryReadClient.java 58.97% <0.00%> (-2.01%) 10.00% <0.00%> (-2.00%)
...igquery/storage/v1beta1/BigQueryStorageClient.java 68.75% <0.00%> (-1.84%) 16.00% <0.00%> (-3.00%)
.../cloud/bigquery/storage/v1/BigQueryReadClient.java 51.51% <0.00%> (-1.43%) 8.00% <0.00%> (-1.00%)
...d/bigquery/storage/v1beta2/BigQueryReadClient.java 51.51% <0.00%> (-1.43%) 8.00% <0.00%> (-1.00%)
.../bigquery/storage/v1beta2/BigQueryWriteClient.java 74.13% <0.00%> (-1.25%) 26.00% <0.00%> (-7.00%)
...bigquery/storage/v1/stub/GrpcBigQueryReadStub.java 88.88% <0.00%> (-0.65%) 9.00% <0.00%> (-1.00%)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0261af4...74bb949. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 854c81e into googleapis:master Feb 23, 2021
@yayi-google yayi-google deleted the inflight-control branch February 25, 2021 01:27
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@release-please
chore(main): release 0.123.27 (googleapis#875)
d5e9d02 
🤖 I have created a release *beep* *boop*
---


### [0.123.27](googleapis/java-storage-nio@v0.123.26...v0.123.27) (2022-03-29)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.9.0 ([googleapis#873](googleapis/java-storage-nio#873)) ([485cf03](googleapis/java-storage-nio@485cf03))
* update dependency com.google.cloud:google-cloud-storage to v2.5.1 ([googleapis#872](googleapis/java-storage-nio#872)) ([5a6a664](googleapis/java-storage-nio@5a6a664))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigang-li bigang-li bigang-li approved these changes

@yirutang yirutang yirutang approved these changes

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yayi-google @stephaniewang526 @yirutang @bigang-li