Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove IgnoreUnknownFields support on JsonStreamWriter #755

Closed
wants to merge 11 commits into from
Closed

feat: Remove IgnoreUnknownFields support on JsonStreamWriter #755

wants to merge 11 commits into from

Conversation

yirutang
Copy link
Contributor

IgnoreUnknownFields is no longer supported on API level. So make JsonStreamWriter consistent with it.

@yirutang yirutang requested a review from a team December 30, 2020 08:30
@yirutang yirutang requested a review from a team as a code owner December 30, 2020 08:30
@yirutang yirutang requested a review from steffnay December 30, 2020 08:30
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 30, 2020
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Dec 30, 2020
@codecov
Copy link

codecov bot commented Dec 30, 2020 •
edited
Loading

Codecov Report

Merging #755 (efb529f) into master (8caf5a2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #755      +/-   ##
============================================
- Coverage     80.80%   80.80%   -0.01%     
+ Complexity      985      983       -2     
============================================
  Files            73       73              
  Lines          5289     5283       -6     
  Branches        406      404       -2     
============================================
- Hits           4274     4269       -5     
+ Misses          845      844       -1     
  Partials        170      170
Impacted Files Coverage Δ Complexity Δ
...oud/bigquery/storage/v1beta2/JsonStreamWriter.java 77.87% <100.00%> (+0.68%) 13.00 <1.00> (+1.00)
...d/bigquery/storage/v1beta2/JsonToProtoMessage.java 96.85% <100.00%> (-0.12%) 44.00 <0.00> (-3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8caf5a2...0032d7f. Read the comment docs.

@yirutang yirutang changed the title feat! Remove IgnoreUnknownFields support on JsonStreamWriter BREAKING CHANGE: Remove IgnoreUnknownFields support on JsonStreamWriter Dec 30, 2020
@yirutang yirutang changed the title BREAKING CHANGE: Remove IgnoreUnknownFields support on JsonStreamWriter feat: Remove IgnoreUnknownFields support on JsonStreamWriter Dec 30, 2020
yirutang referenced this pull request in VeronicaWasson/java-bigquerystorage Dec 30, 2020
@VeronicaWasson
Code snippets for WriteAPI
9419d34
@stephaniewang526 stephaniewang526 mentioned this pull request Dec 30, 2020
Merged
@stephaniewang526
Copy link
Contributor

Resolving binary compat issue in #757

@yirutang yirutang deleted the removeignore branch February 18, 2021 00:10
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@gcf-owl-bot
Update ci.yaml (googleapis#1275) (googleapis#755)
7310d5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffnay steffnay Awaiting requested review from steffnay

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yirutang @stephaniewang526