feat: v1beta2 manual client library for BigQueryWrite #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquerystorage
google-cla
bot
added
the
cla: yes
.../src/main/java/com/google/cloud/bigquery/storage/v1beta2/BQTableSchemaToProtoDescriptor.java
Show resolved
Hide resolved
...igquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java
Show resolved
Hide resolved
...querystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonToProtoMessage.java
Show resolved
Hide resolved
...ystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/OnSchemaUpdateRunnable.java
Show resolved
Hide resolved
...erystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/ProtoSchemaConverter.java
Show resolved
Hide resolved
...ystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/JsonToProtoMessageTest.java
Show resolved
Hide resolved
...torage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/ProtoSchemaConverterTest.java
Show resolved
Hide resolved
...storage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/SchemaCompatibilityTest.java
Show resolved
Hide resolved
...igquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterTest.java
Show resolved
Hide resolved
.../test/java/com/google/cloud/bigquery/storage/v1beta2/it/ITBigQueryWriteManualClientTest.java
Show resolved
Hide resolved
…gquery/storage/v1beta2/JsonStreamWriter.java Co-authored-by: yoshi-code-bot <[email protected]>
…gquery/storage/v1beta2/OnSchemaUpdateRunnable.java Co-authored-by: yoshi-code-bot <[email protected]>
Co-authored-by: yoshi-code-bot <[email protected]>
yirutang
changed the title
Co-authored-by: yoshi-code-bot <[email protected]>
|
@yirutang there are a number of checkstyle errors: https://github.com/googleapis/java-bigquerystorage/pull/714/checks?check_run_id=1514447927. Running |
|
I ran it and they are all under alpha automatic generated libraries:
[*ERROR*]
src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java:[1]
(javadoc) JavadocPackage: Missing package-info.java file.
[*ERROR*]
src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java:[27]
(javadoc) JavadocStyle: First sentence should end with a period.
[*ERROR*]
src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java:[28,1]
(design) FinalClass: Class WriteStreamName should be declared as final.
[*ERROR*]
src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java:[31,3]
(javadoc) JavadocVariable: Missing a Javadoc comment.
[*ERROR*]
src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java:[33]
(sizes) LineLength: Line is longer than 80 characters (found 83).
[*ERROR*]
src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java:[35,3]
(javadoc) JavadocVariable: Missing a Javadoc comment.
[*ERROR*]
src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java:[37,3]
(javadoc) JavadocVariable: Missing a Javadoc comment.
[*ERROR*]
src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java:[38,3]
(javadoc) JavadocVariable: Missing a Javadoc comment.
[*ERROR*]
src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java:[39,3]
(javadoc) JavadocVariable: Missing a Javadoc comment.
[*ERROR*]
src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java:[40,3]
(javadoc) JavadocVariable: Missing a Javadoc comment.
[*ERROR*]
src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java:[42,3]
(javadoc) MissingJavadocMethod: Missing a Javadoc comment.
[*ERROR*]
src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java:[46,3]
(javadoc) MissingJavadocMethod: Missing a Javadoc comment.
...
I didn't touch those files in this PR. How to fix them?
…On Tue, Dec 8, 2020 at 9:33 AM Stephanie Wang ***@***.***> wrote:
@yirutang <https://github.com/yirutang> there are a number of checkstyle
errors:
https://github.com/googleapis/java-bigquerystorage/pull/714/checks?check_run_id=1514447927.
Running mvn checkstyle:check can repro locally.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#714 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHGYVESF3REWJ7PJDW7BSNTSTZPM5ANCNFSM4URHEHQQ>
.
--
Thanks.
Yiru
|
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
============================================
+ Coverage 78.79% 80.42% +1.63%
- Complexity 718 959 +241
============================================
Files 65 73 +8
Lines 4263 5334 +1071
Branches 253 405 +152
============================================
+ Hits 3359 4290 +931
- Misses 786 877 +91
- Partials 118 167 +49
Continue to review full report at Codecov.
|
| @@ -1,7 +1,6 @@ | |||
| /* | |||
| * Copyright 2020 Google LLC | |||
| * | |||
There was a problem hiding this comment.
The bot incorrectly proposed these changes. Raised this issue to track a fix.
|
Yeah, pushed in a fix.
…On Tue, Dec 8, 2020 at 10:55 AM Stephanie Wang ***@***.***> wrote:
@yirutang <https://github.com/yirutang>
https://github.com/googleapis/java-bigquerystorage/pull/714/checks?check_run_id=1519341215#step:5:7895
--> flaky test?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#714 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHGYVEXVZL6VFVFWOWPMDADSTZZCLANCNFSM4URHEHQQ>
.
--
Thanks.
Yiru
|
|
One more IT failure: |
Comment on lines
22
to
23
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.Assert.fail; |
There was a problem hiding this comment.
Suggested change
| import static org.junit.Assert.assertTrue; | |
| import static org.junit.Assert.fail; | |
| import static org.junit.Assert.assertTrue; |
stephaniewang526
approved these changes
Dec 9, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 9, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.7.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.6.7...v1.7.0) (2020-12-09) ### Features * v1beta2 manual client library for BigQueryWrite ([#714](https://www.github.com/googleapis/java-bigquerystorage/issues/714)) ([53a9c3a](https://www.github.com/googleapis/java-bigquerystorage/commit/53a9c3aaf7e6a17d10ceecaf9cef5eb3e81a58ee)) ### Dependencies * update dependency com.google.cloud:google-cloud-bigquery to v1.126.0 ([#708](https://www.github.com/googleapis/java-bigquerystorage/issues/708)) ([24a98c8](https://www.github.com/googleapis/java-bigquerystorage/commit/24a98c88b5531210efa8ba7b474f89d9b790df16)) * update dependency com.google.cloud:google-cloud-bigquery to v1.126.1 ([#716](https://www.github.com/googleapis/java-bigquerystorage/issues/716)) ([03aa545](https://www.github.com/googleapis/java-bigquerystorage/commit/03aa5455baf29e10b5938829f340ce865574453d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
…onfig to v1.0.3 (googleapis#714) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.0.2` -> `1.0.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.0.3`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#​103-httpswwwgithubcomgoogleapisjava-shared-configcomparev102v103-2021-09-21) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.0.2...v1.0.3) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-storage-nio).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️