Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate tests off TextPrinter's deprecated methods #2506

Merged
merged 2 commits into from
May 24, 2024
Merged

chore: Migrate tests off TextPrinter's deprecated methods #2506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bdc778
chore: Migrate tests off TextPrinter's deprecated methods
lqiu96 May 17, 2024
b8fb8dc
Merge branch 'main' into protobufjava-426x-compatibility
lqiu96 May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...t/java/com/google/cloud/bigquery/storage/v1beta1/it/ITBigQueryStorageLongRunningTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public void testLongRunningReadSession() throws InterruptedException, ExecutionE
assertEquals(
String.format(
"Did not receive expected number of streams for table reference '%s' CreateReadSession response:%n%s",
TextFormat.shortDebugString(tableReference), session.toString()),
TextFormat.printer().shortDebugString(tableReference), session.toString()),
5,
session.getStreamsCount());

Expand Down
16 changes: 8 additions & 8 deletions ...age/src/test/java/com/google/cloud/bigquery/storage/v1beta1/it/ITBigQueryStorageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ public void testSimpleRead() {
assertEquals(
String.format(
"Did not receive expected number of streams for table reference '%s' CreateReadSession response:%n%s",
TextFormat.shortDebugString(tableReference), session.toString()),
TextFormat.printer().shortDebugString(tableReference), session.toString()),
1,
session.getStreamsCount());

Expand Down Expand Up @@ -246,7 +246,7 @@ public void testSimpleReadArrow() {
assertEquals(
String.format(
"Did not receive expected number of streams for table reference '%s' CreateReadSession response:%n%s",
TextFormat.shortDebugString(tableReference), session.toString()),
TextFormat.printer().shortDebugString(tableReference), session.toString()),
1,
session.getStreamsCount());

Expand Down Expand Up @@ -300,7 +300,7 @@ public void testRangeType() throws InterruptedException {
assertEquals(
String.format(
"Did not receive expected number of streams for table reference '%s' CreateReadSession response:%n%s",
TextFormat.shortDebugString(tableReference), session.toString()),
TextFormat.printer().shortDebugString(tableReference), session.toString()),
1,
session.getStreamsCount());

Expand Down Expand Up @@ -337,7 +337,7 @@ public void testSimpleReadAndResume() {
assertEquals(
String.format(
"Did not receive expected number of streams for table reference '%s' CreateReadSession response:%n%s",
TextFormat.shortDebugString(tableReference), session.toString()),
TextFormat.printer().shortDebugString(tableReference), session.toString()),
1,
session.getStreamsCount());

Expand Down Expand Up @@ -388,7 +388,7 @@ public void testFilter() throws IOException {
assertEquals(
String.format(
"Did not receive expected number of streams for table reference '%s' CreateReadSession response:%n%s",
TextFormat.shortDebugString(tableReference), session.toString()),
TextFormat.printer().shortDebugString(tableReference), session.toString()),
1,
session.getStreamsCount());

Expand Down Expand Up @@ -451,7 +451,7 @@ public void testColumnSelection() throws IOException {
assertEquals(
String.format(
"Did not receive expected number of streams for table reference '%s' CreateReadSession response:%n%s",
TextFormat.shortDebugString(tableReference), session.toString()),
TextFormat.printer().shortDebugString(tableReference), session.toString()),
1,
session.getStreamsCount());

Expand Down Expand Up @@ -1079,7 +1079,7 @@ public void testUniverseDomainWithMatchingDomain() throws IOException {
assertEquals(
String.format(
"Did not receive expected number of streams for table reference '%s' CreateReadSession response:%n%s",
TextFormat.shortDebugString(tableReference), session.toString()),
TextFormat.printer().shortDebugString(tableReference), session.toString()),
1,
session.getStreamsCount());

Expand Down Expand Up @@ -1208,7 +1208,7 @@ private void ProcessRowsAtSnapshot(
assertEquals(
String.format(
"Did not receive expected number of streams for table reference '%s' CreateReadSession response:%n%s",
TextFormat.shortDebugString(tableReference), session.toString()),
TextFormat.printer().shortDebugString(tableReference), session.toString()),
1,
session.getStreamsCount());

Expand Down
Loading