Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Close stream connection before each retry #1975

Merged
merged 83 commits into from
Feb 6, 2023
Merged

fix: Close stream connection before each retry #1975

merged 83 commits into from
Feb 6, 2023

Conversation

GaoleMeng
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

GaoleMeng and others added 30 commits September 13, 2022 01:58
@GaoleMeng
feat: Split writer into connection worker and wrapper, this is a
5a63d95 
prerequisite for multiplexing client
@GaoleMeng
feat: add connection worker pool skeleton, used for multiplexing client
5a13302
@GaoleMeng
Merge branch 'main' into main
0297204
@GaoleMeng
feat: add Load api for connection worker for multiplexing client
8a81ad3
@GaoleMeng
Merge remote-tracking branch 'upstream/main'
68fd040
@GaoleMeng
Merge remote-tracking branch 'upstream/main'
3106dae
@GaoleMeng
Merge branch 'googleapis:main' into main
5bf04e5
@GaoleMeng
Merge branch 'main' of https://github.com/GaoleMeng/java-bigquerystorage
2fc7551
@GaoleMeng
feat: add multiplexing support to connection worker. We will treat every
7a6d919 
new stream name as a switch of destinationt
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
3ba7659 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot @GaoleMeng
Updates from OwlBot post-processor
f379a78 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
Merge branch 'main' of https://github.com/GaoleMeng/java-bigquerystorage
9307776
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
de73013 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
feat: port the multiplexing client core algorithm and basic tests
19005a1 
also fixed a tiny bug inside fake bigquery write impl for getting thre
response from offset
@GaoleMeng
Merge branch 'googleapis:main' into main
c5d14ba
@gcf-owl-bot @GaoleMeng
🦉 Updates from OwlBot post-processor
644360a 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
Merge branch 'googleapis:main' into main
3099d82
@GaoleMeng
Merge branch 'googleapis:main' into main
e707dd6
@GaoleMeng
Merge branch 'main' of https://github.com/GaoleMeng/java-bigquerystorage
9e7a8fa
@GaoleMeng
Merge branch 'googleapis:main' into main
31f1755
@GaoleMeng
feat: wire multiplexing connection pool to stream writer
44c36fc
@GaoleMeng
feat: some fixes for multiplexing client
87a4036
@GaoleMeng
Merge remote-tracking branch 'upstream/main'
c92ea1b
@GaoleMeng
Merge branch 'googleapis:main' into main
019520c
@GaoleMeng
feat: fix some todos, and reject the mixed behavior of passed in clie…
47893df 
…nt or not
@GaoleMeng
Merge remote-tracking branch 'upstream/main'
8bd4e6a
@GaoleMeng
Merge remote-tracking branch 'upstream/main'
83409b0
@GaoleMeng
Merge branch 'googleapis:main' into main
f7dd72d
@GaoleMeng
Merge branch 'googleapis:main' into main
a48399f
@GaoleMeng
feat: fix the bug that we may peek into the write_stream field but it's
6789bc9 
possible the proto schema does not contain this field
GaoleMeng and others added 16 commits January 19, 2023 17:48
@GaoleMeng
Merge branch 'googleapis:main' into main
05edc2f
@GaoleMeng
Merge branch 'googleapis:main' into main
7d3da74
@GaoleMeng
Merge branch 'googleapis:main' into main
ecf6807
@GaoleMeng
Merge branch 'googleapis:main' into main
057dab9
@GaoleMeng
fix: fix one potential root cause of deadlock issue for non-multiplexing
5db46a2 
case
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
32e9d33 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
Merge branch 'googleapis:main' into main
183941a
@GaoleMeng
Add timeout to inflight queue waiting, and also add some extra log
f93f89e
@GaoleMeng
Merge branch 'googleapis:main' into main
e2ec7e7
@GaoleMeng
feat: allow java client lib handle switch table schema for the same s…
1be6ab4 
…tream

name
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
544f063 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
Merge branch 'googleapis:main' into main
3cf5482
@GaoleMeng
Merge branch 'googleapis:main' into main
d9da007
@GaoleMeng
Merge branch 'main' of https://github.com/GaoleMeng/java-bigquerystorage
4626857
@GaoleMeng
Merge branch 'googleapis:main' into main
146bf95
@GaoleMeng
fix: close before retry connection
dde2c6b
@GaoleMeng GaoleMeng requested review from a team and shollyman February 6, 2023 06:05
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Feb 6, 2023
@GaoleMeng GaoleMeng requested a review from yirutang February 6, 2023 06:05
@GaoleMeng GaoleMeng changed the title Close stream connection before each retry fix: Close stream connection before each retry Feb 6, 2023
@GaoleMeng GaoleMeng added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2023
@GaoleMeng GaoleMeng merged commit 54e9bb9 into googleapis:main Feb 6, 2023
@release-please release-please bot mentioned this pull request Feb 6, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 6, 2023
@release-please
chore(main): release 2.30.0 (#1976)
423ee19 
🤖 I have created a release *beep* *boop*
---


## [2.30.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.29.0...v2.30.0) (2023-02-06)


### Features

* Add userClose flag back to StreamWriter ([#1973](https://togithub.com/googleapis/java-bigquerystorage/issues/1973)) ([4b51acd](https://togithub.com/googleapis/java-bigquerystorage/commit/4b51acd49292d99e1c3cd670bec695b8bcd3b5c4))


### Bug Fixes

* Close stream connection before each retry ([#1975](https://togithub.com/googleapis/java-bigquerystorage/issues/1975)) ([54e9bb9](https://togithub.com/googleapis/java-bigquerystorage/commit/54e9bb9116eb9781b6f2266f98de4d3853a469b8))
* Improve ConnectionWorker fine logging ([#1972](https://togithub.com/googleapis/java-bigquerystorage/issues/1972)) ([812bcf1](https://togithub.com/googleapis/java-bigquerystorage/commit/812bcf16efdc7a1797435f0b87430c35f27f7245))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yirutang yirutang yirutang approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaoleMeng @yirutang