Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing field error to row error message #1752

Merged
merged 15 commits into from
Aug 17, 2022
Merged

fix: Add missing field error to row error message #1752

merged 15 commits into from
Aug 17, 2022

Conversation

yirutang
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@yirutang yirutang requested review from a team and loferris August 16, 2022 19:28
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Aug 16, 2022
@yirutang yirutang requested a review from gnanda August 16, 2022 19:28
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Aug 16, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 16, 2022
@yirutang yirutang changed the title fix: Add field error to row error message fix: Add missing field error to row error message Aug 16, 2022
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
gnanda
gnanda approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@gnanda gnanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now in case we need to get them unblocked, but ideally the other way should be easier to maintain

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Aug 16, 2022
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2022
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2022
@yirutang yirutang merged commit 186d213 into googleapis:main Aug 17, 2022
@release-please release-please bot mentioned this pull request Aug 17, 2022
Merged
gcf-owl-bot bot added a commit that referenced this pull request Jan 19, 2023
@gcf-owl-bot @dependabot
build(deps): bump protobuf from 3.20.1 to 3.20.2 in /synthtool/gcp/te…
0152b3d 
…mplates/java_library/.kokoro (#1752)

build(deps): bump protobuf

Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 3.20.1 to 3.20.2.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py)
- [Commits](protocolbuffers/protobuf@v3.20.1...v3.20.2)

---
updated-dependencies:
- dependency-name: protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@239f962
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d5da32501662e4e53365220cc14cfb1d3b9446585397d57dac50171d92556ae7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-zhang-exa justin-zhang-exa justin-zhang-exa left review comments

@gnanda gnanda gnanda approved these changes

@loferris loferris Awaiting requested review from loferris

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yirutang @gnanda @justin-zhang-exa