Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for StorageError #1391

Merged
merged 19 commits into from
Nov 15, 2021
Merged

feat: add support for StorageError #1391

merged 19 commits into from
Nov 15, 2021

Conversation

stephaniewang526
Copy link
Contributor

Fixes b/203003176

@stephaniewang526 stephaniewang526 requested review from a team and shollyman October 29, 2021 15:52
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Oct 29, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2021
@stephaniewang526 stephaniewang526 requested a review from a team as a code owner October 29, 2021 15:54
yirutang
yirutang reviewed Oct 29, 2021
View reviewed changes
Copy link
Contributor

@yirutang yirutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there is a missing part, is there a way to add the same process when the API call failed, aka, in terms of connection error?

It is when the Done function is called on AppendRows.

BenWhitehead
BenWhitehead reviewed Nov 4, 2021
View reviewed changes
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Outdated Show resolved Hide resolved
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Outdated Show resolved Hide resolved
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Outdated Show resolved Hide resolved
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Outdated Show resolved Hide resolved
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Outdated Show resolved Hide resolved
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Outdated Show resolved Hide resolved
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Show resolved Hide resolved
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Outdated Show resolved Hide resolved
BenWhitehead
BenWhitehead requested changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two bugs, and the reason your tests builds are all hung and will likely need to timeout.

An exception is being thrown because the map is null while trying to initialize the exception most likely going into a loop or something.

google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Outdated Show resolved Hide resolved
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java Outdated Show resolved Hide resolved
yirutang
yirutang approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@yirutang yirutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Nov 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 13, 2021
@steffnay steffnay merged commit 176dc8b into main Nov 15, 2021
@steffnay steffnay deleted the storageError branch November 15, 2021 17:35
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 15, 2021
@release-please
chore: release 2.6.0 (#1403)
30939c8 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.6.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v2.5.1...v2.6.0) (2021-11-15)


### Features

* add support for StorageError ([#1391](https://www.github.com/googleapis/java-bigquerystorage/issues/1391)) ([176dc8b](https://www.github.com/googleapis/java-bigquerystorage/commit/176dc8b1fa30cf9a9a98628bd83c9ab487ddb094))
* DATE and DOUBLE support more input formats ([#1397](https://www.github.com/googleapis/java-bigquerystorage/issues/1397)) ([9c8dc0a](https://www.github.com/googleapis/java-bigquerystorage/commit/9c8dc0aabb471fdb8580f434cc5a66bad585e8f2))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.0 ([#1406](https://www.github.com/googleapis/java-bigquerystorage/issues/1406)) ([38f5eb9](https://www.github.com/googleapis/java-bigquerystorage/commit/38f5eb9788e1f090c0034a789a512dcec2384fdb))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yirutang yirutang yirutang approved these changes

@steffnay steffnay steffnay approved these changes

@Neenu1995 Neenu1995 Neenu1995 approved these changes

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephaniewang526 @BenWhitehead @Neenu1995 @steffnay @yirutang