fix: Make EOS Matching more robust #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Make EOS Matching more robust Clients are seeing a different variant now: Received unexpected EOS on empty DATA frame from server
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
product-auto-label
bot
added
the
api: bigquerystorage
google-cla
bot
added
the
cla: yes
emkornfield
referenced
this pull request
in grpc/grpc-java
Jun 11, 2021
Empty DATA frames with EOS tell a stronger tale as to where the server may have its bug.
|
It looks like grpc/grpc-java@60d3e7c broke the logic |
|
@stephaniewang526 would you mind taking a look. |
|
Integration test failure looks related to the write functionality |
shollyman
approved these changes
Jun 11, 2021
shollyman
added
the
kokoro:force-run
|
re-running to get around the loadshed failure |
yoshi-kokoro
removed
the
kokoro:force-run
shollyman
added
automerge
|
Still getting loadshedding responses from the write backend |
shollyman
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 11, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.22.3](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.22.2...v1.22.3) (2021-06-11) ### Bug Fixes * Make EOS Matching more robust ([#1128](https://www.github.com/googleapis/java-bigquerystorage/issues/1128)) ([3b5cdbe](https://www.github.com/googleapis/java-bigquerystorage/commit/3b5cdbe769fcebeebc571922c84c129066e76aaf)) ### Dependencies * update dependency com.google.cloud:google-cloud-bigquery to v1.133.0 ([#1124](https://www.github.com/googleapis/java-bigquerystorage/issues/1124)) ([aea80e9](https://www.github.com/googleapis/java-bigquerystorage/commit/aea80e930ac5a9cb5fa8f751c977166d45f1341f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Make EOS Matching more robust
Clients are seeing a different variant now: Received unexpected EOS on empty DATA frame from server
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️