-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove v1alpha2 library #1003
Conversation
Warning: This pull request is touching the following templated files:
|
Codecov Report
@@ Coverage Diff @@
## master #1003 +/- ##
============================================
- Coverage 81.03% 80.00% -1.03%
+ Complexity 1045 709 -336
============================================
Files 78 61 -17
Lines 5668 3961 -1707
Branches 435 264 -171
============================================
- Hits 4593 3169 -1424
+ Misses 889 669 -220
+ Partials 186 123 -63 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to remove it from the bom, versions.txt and synth.py.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the !
from the initial commit?
done. I thought I already did it somehow... |
Great!
…On Thu, Apr 15, 2021 at 9:36 AM Stephanie Wang ***@***.***> wrote:
Merged #1003
<#1003> into
master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1003 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHGYVEXJDPXTXLXXFXCZ663TI4IZBANCNFSM4237SWGQ>
.
--
Thanks.
Yiru
|
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️