Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clients should be able to build DynamicMessage #1744

Closed
dark0dave opened this issue Aug 11, 2022 · 2 comments
Closed

Clients should be able to build DynamicMessage #1744

dark0dave opened this issue Aug 11, 2022 · 2 comments
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API.

Comments

@dark0dave
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Can be large latency in the convertJsonToProtoMessageImpl for lots of messages.

Describe the solution you'd like
I would like the api to accept DynamicMessages without using convertJsonToProtoMessageImpl
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Aug 11, 2022
@yirutang
Copy link
Contributor

These are public proto libs:

import com.google.protobuf.Descriptors.Descriptor;
import com.google.protobuf.Descriptors.FieldDescriptor;
import com.google.protobuf.DynamicMessage;
import com.google.protobuf.Message;

You can use them directly.

@dark0dave
Copy link
Contributor Author

@yirutang thanks.

gcf-owl-bot bot added a commit that referenced this issue Jan 19, 2023
@gcf-owl-bot
fix(java): skip fixing poms for special modules (#1744)
b72edb5 
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1
Neenu1995 pushed a commit that referenced this issue Jan 19, 2023
@gcf-owl-bot
fix(java): skip fixing poms for special modules (#1744) (#1946)
2863542 
fix(java): handle empty modules

Fixes googleapis/synthtool#1743
Source-Link: googleapis/synthtool@482d649
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:bd5071596a47614d1fe15eb766c4255bae330f823b606e1196a3b0c8d2e96fd1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@release-please release-please bot mentioned this issue Jan 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yirutang @dark0dave