fix: remove dependency on google-cloud-bigquery (cyclic dep) #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquerystorage
|
Warning: This pull request is touching the following templated files:
|
stephaniewang526
force-pushed
the
refactor
branch
from
99f900c to
60c5462
Compare
yirutang
reviewed
Sep 8, 2021
.../test/java/com/google/cloud/bigquery/storage/v1beta2/it/ITBigQueryWriteManualClientTest.java
Show resolved
Hide resolved
yirutang
approved these changes
Sep 8, 2021
| @@ -39,27 +37,31 @@ public static void runWriteToDefaultStream() | |||
| String projectId = "MY_PROJECT_ID"; | |||
| String datasetName = "MY_DATASET_NAME"; | |||
| String tableName = "MY_TABLE_NAME"; | |||
|
|
|||
| writeToDefaultStream(projectId, datasetName, tableName); | |||
| TableFieldSchema strField = | |||
There was a problem hiding this comment.
I would suggest keep the sample the way it is. Move BQV2ToBQStorageConverter.java into sample as a lib, and the sample would still do a GetTable(), use BQV2ToBQStorageConverter to convert the schema and then use JsonWriter. It doesn't need to block this PR.
There was a problem hiding this comment.
Sure. Will make this change in a separate PR.
tswast
approved these changes
Sep 8, 2021
| @@ -47,11 +47,11 @@ function completenessCheck() { | |||
| # This is stripped from the output as it is not present in the flattened pom. | |||
| # Only dependencies with 'compile' or 'runtime' scope are included from original dependency list. | |||
| msg "Generating dependency list using original pom..." | |||
| mvn dependency:list -f pom.xml -DincludeScope=runtime -Dsort=true | grep '\[INFO] .*:.*:.*:.*:.*' | sed -e 's/ --.*//' >.org-list.txt | |||
| mvn dependency:list -f pom.xml -DincludeScope=runtime -DexcludeArtifactIds=gson,commons-codec,commons-logging,opencensus-contrib-http-util,httpclient,httpcore -Dsort=true | grep '\[INFO] .*:.*:.*:.*:.*' | sed -e 's/ --.*//' >.org-list.txt | |||
There was a problem hiding this comment.
Where is this exclusion list coming from? A template?
There was a problem hiding this comment.
Yes indeed. It comes from synthtool. There is a bug in maven-dependency-plugin which is causing this issue: https://issues.apache.org/jira/browse/MDEP-737
So we temporarily add this exclusion as a workaround.
stephaniewang526
added
automerge
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1249