-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor write client code to use the generated instead of the handwritten BigQuery client #1249
Labels
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
type: cleanup
An internal cleanup or hygiene concern.
Comments
product-auto-label
bot
added
the
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
label
Aug 19, 2021
stephaniewang526
changed the title
fix: refactor write client code to use the generated instead of the handwritten BigQuery client
Refactor write client code to use the generated instead of the handwritten BigQuery client
Aug 24, 2021
stephaniewang526
added a commit
that referenced
this issue
Sep 7, 2021
stephaniewang526
added a commit
that referenced
this issue
Sep 9, 2021
Towards #1249 BQToBQStorageSchemaConverter.java will go into google-cloud-bigquery eventually. For now it acts as a resource for developers who want to use default stream to write.
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Sep 10, 2021
Towards #1249 BQToBQStorageSchemaConverter.java will go into google-cloud-bigquery eventually. For now it acts as a resource for developers who want to use default stream to write.
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this issue
Oct 7, 2023
…o v1-rev20230907-2.0.0 (googleapis#1249)
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this issue
Oct 7, 2023
🤖 I have created a release *beep* *boop* --- ## [0.127.3](https://togithub.com/googleapis/java-storage-nio/compare/v0.127.2...v0.127.3) (2023-09-13) ### Dependencies * Update actions/checkout action to v4 ([googleapis#1245](https://togithub.com/googleapis/java-storage-nio/issues/1245)) ([9d0a175](https://togithub.com/googleapis/java-storage-nio/commit/9d0a17581020058a35c592dce895a7e601faf584)) * Update dependency com.google.apis:google-api-services-storage to v1-rev20230710-2.0.0 ([googleapis#1238](https://togithub.com/googleapis/java-storage-nio/issues/1238)) ([51b12aa](https://togithub.com/googleapis/java-storage-nio/commit/51b12aa6044407220f8461e92c673607406fd719)) * Update dependency com.google.apis:google-api-services-storage to v1-rev20230907-2.0.0 ([googleapis#1249](https://togithub.com/googleapis/java-storage-nio/issues/1249)) ([d362b23](https://togithub.com/googleapis/java-storage-nio/commit/d362b230aae976ab2ff1eb92da67f34da38fe183)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.15.0 ([googleapis#1248](https://togithub.com/googleapis/java-storage-nio/issues/1248)) ([173db6b](https://togithub.com/googleapis/java-storage-nio/commit/173db6b6f5dd83a0c25e43f28fe8bf6a28c73c9a)) * Update dependency com.google.cloud:google-cloud-storage to v2.26.1 ([googleapis#1239](https://togithub.com/googleapis/java-storage-nio/issues/1239)) ([2a0866a](https://togithub.com/googleapis/java-storage-nio/commit/2a0866adc21f0df5370d20f942a47c5f7cd57496)) * Update dependency com.google.cloud:google-cloud-storage to v2.27.0 ([googleapis#1250](https://togithub.com/googleapis/java-storage-nio/issues/1250)) ([cd51778](https://togithub.com/googleapis/java-storage-nio/commit/cd51778387c2635df29fabb445be19505492c9d2)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
type: cleanup
An internal cleanup or hygiene concern.
The fact that google-cloud-bigquerystorage Write client (v1beta2) is using google-cloud-bigquery as a dependency means it would introduce a cyclic dependency when we integrate it into google-cloud-bigquery for high throughput Write in the future. This is also currently blocking us from using google-cloud-bigquerystorage client in google-cloud-bigquery for the Read API features (v1). We have found a temporary workaround to unblock ourselves on the Read side but this refactoring is necessary before we GA this client.
Specifically, 3 classes require full refactoring:
/usr/local/google/home/stephwang/Desktop/stephdev/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/SchemaCompatibility.java:
/usr/local/google/home/stephwang/Desktop/stephdev/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/BQV2ToBQStorageConverter.java:
/usr/local/google/home/stephwang/Desktop/stephdev/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java:
Full trace:
The text was updated successfully, but these errors were encountered: