feat: Improve client settings (#2097)

* feat: Add necessary client settings to sample * feat: Add keepalive to default setting and also add it to samples * . * . * . * . * . * . * . * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
googleapis · May 3, 2023 · 4fc2fac · 4fc2fac
1 parent bcd7fc9
commit 4fc2fac
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/...loud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java b/...loud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java
@@ -318,7 +318,10 @@ static BigQueryWriteSettings getBigQueryWriteSettings(Builder builder) throws IO
           new BigQueryWriteSettings.Builder()
               .setTransportChannelProvider(
                   BigQueryWriteSettings.defaultGrpcTransportProviderBuilder()
-                      .setChannelsPerCpu(1)
+                      .setKeepAliveTime(org.threeten.bp.Duration.ofMinutes(1))
+                      .setKeepAliveTimeout(org.threeten.bp.Duration.ofMinutes(1))
+                      .setKeepAliveWithoutCalls(true)
+                      .setChannelsPerCpu(2)
                       .build())
               .setCredentialsProvider(
                   BigQueryWriteSettings.defaultCredentialsProviderBuilder().build())

diff --git a/...-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/StreamWriterTest.java b/...-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/StreamWriterTest.java
@@ -1413,6 +1413,17 @@ public void testBuilderDefaultSetting() throws Exception {
         writeSettings.getCredentialsProvider().toString());
     assertTrue(
         writeSettings.getTransportChannelProvider() instanceof InstantiatingGrpcChannelProvider);
+    assertTrue(
+        ((InstantiatingGrpcChannelProvider) writeSettings.getTransportChannelProvider())
+            .getKeepAliveWithoutCalls());
+    assertEquals(
+        ((InstantiatingGrpcChannelProvider) writeSettings.getTransportChannelProvider())
+            .getKeepAliveTimeout(),
+        org.threeten.bp.Duration.ofMinutes(1));
+    assertEquals(
+        ((InstantiatingGrpcChannelProvider) writeSettings.getTransportChannelProvider())
+            .getKeepAliveTime(),
+        org.threeten.bp.Duration.ofMinutes(1));
     assertEquals(
         BigQueryWriteSettings.getDefaultEndpoint(), writeSettings.getEndpoint().toString());
   }

diff --git a/samples/snippets/src/main/java/com/example/bigquerystorage/WriteToDefaultStream.java b/samples/snippets/src/main/java/com/example/bigquerystorage/WriteToDefaultStream.java
@@ -21,6 +21,7 @@
 import com.google.api.core.ApiFuture;
 import com.google.api.core.ApiFutureCallback;
 import com.google.api.core.ApiFutures;
+import com.google.api.gax.core.FixedExecutorProvider;
 import com.google.cloud.bigquery.BigQuery;
 import com.google.cloud.bigquery.BigQueryOptions;
 import com.google.cloud.bigquery.QueryJobConfiguration;
@@ -39,6 +40,7 @@
 import io.grpc.Status.Code;
 import java.io.IOException;
 import java.util.Map;
+import java.util.concurrent.Executors;
 import java.util.concurrent.Phaser;
 import java.util.concurrent.atomic.AtomicInteger;
 import javax.annotation.concurrent.GuardedBy;
@@ -151,7 +153,10 @@ public void initialize(TableName parentTable)
       // For more information about JsonStreamWriter, see:
       // https://googleapis.dev/java/google-cloud-bigquerystorage/latest/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.html
       streamWriter =
-          JsonStreamWriter.newBuilder(parentTable.toString(), BigQueryWriteClient.create()).build();
+          JsonStreamWriter.newBuilder(parentTable.toString(), BigQueryWriteClient.create())
+              .setExecutorProvider(
+                  FixedExecutorProvider.create(Executors.newScheduledThreadPool(100)))
+              .build();
     }
 
     public void append(AppendContext appendContext)