Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for concurrent XML MPU uploads #395

Merged
merged 18 commits into from
Sep 6, 2023
Merged

feat: add support for concurrent XML MPU uploads #395

merged 18 commits into from
Sep 6, 2023

Conversation

andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Aug 16, 2023 •
edited
Loading

No description provided.

@andrewsg andrewsg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 16, 2023
@andrewsg andrewsg requested review from a team as code owners August 16, 2023 01:01
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/google-resumable-media-python API. labels Aug 16, 2023
cojenco
cojenco reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited for MPU🎉 Making my way through the PR and have a few questions

google/resumable_media/_upload.py Show resolved Hide resolved
google/resumable_media/_upload.py Show resolved Hide resolved
google/resumable_media/_upload.py Show resolved Hide resolved
google/resumable_media/_upload.py Outdated Show resolved Hide resolved
google/resumable_media/_upload.py Show resolved Hide resolved
google/resumable_media/_upload.py Outdated Show resolved Hide resolved
cojenco
cojenco reviewed Aug 25, 2023
View reviewed changes
google/resumable_media/requests/upload.py Outdated Show resolved Hide resolved
tests/unit/test__upload.py Show resolved Hide resolved
tests/unit/test__upload.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Aug 31, 2023
@andrewsg andrewsg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 31, 2023
@andrewsg
Copy link
Contributor Author

PTAL

cojenco
cojenco approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@andrewsg andrewsg mentioned this pull request Sep 2, 2023
Merged
cojenco
cojenco reviewed Sep 6, 2023
View reviewed changes
google/resumable_media/_upload.py Outdated Show resolved Hide resolved
google/resumable_media/_upload.py Show resolved Hide resolved
@andrewsg andrewsg added the automerge Merge the pull request once unit tests and other checks pass. label Sep 6, 2023
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 6, 2023
@andrewsg andrewsg merged commit a8d56bc into main Sep 6, 2023
16 checks passed
@andrewsg andrewsg deleted the mpu branch September 6, 2023 16:20
@release-please release-please bot mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewsg @cojenco