fix: avoid validating checksums for partial responses

[simonbohnen]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #362 🦕

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[parthea]

Hi @simonbohnen,

Please could you sign the CLA?
https://cla.developers.google.com/about

[simonbohnen]

Hi @simonbohnen,

Please could you sign the CLA? https://cla.developers.google.com/about

It looks like I did for my work account (SimonBohnenQC). Is there a way to re-run the check?

[parthea]

@cojenco Please could you take a look?

[cojenco]

Hi @simonbohnen,
Please could you sign the CLA? https://cla.developers.google.com/about

It looks like I did for my work account (SimonBohnenQC). Is there a way to re-run the check?

I force rescanned the CLA and it's passing now. Our team will work on reviewing your PR. Thanks for your contribution!

[cojenco]

Thanks @simonbohnen for the fix. I agree we want to skip checksum validations for partial content responses, as noted in our documentation.

In addition to the comments, could you add a unit test for this? Something alongside the tests here. Let me know if you'd like assistance on testing.

[simonbohnen]

Thanks @simonbohnen for the fix. I agree we want to skip checksum validations for partial content responses, as noted in our documentation.

In addition to the comments, could you add a unit test for this? Something alongside the tests here. Let me know if you'd like assistance on testing.

I'll add some tests next week👌🏼

[simonbohnen]

Can you help me with this error? The commit messages look good to me 🤔

[cojenco]

Thanks for adding tests @simonbohnen

Besides the lint error on unused ret_val in the tests, LGTM. Try running nox -s lint to check linting.

[cojenco]

LGTM, thanks again for your contribution!