Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to old fake gcs server #77

Merged

Conversation

simonbohnen
Copy link
Contributor

@simonbohnen simonbohnen commented Jan 20, 2023

As googleapis/google-resumable-media-python#361 was fixed and is part of a new release, we don't need my patch on the fake-gcs-server side anymore and can use the version by fsouza.

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (34abd38) compared to base (d3bcfd2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #77   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         30      31    +1     
  Lines       1859    1870   +11     
=====================================
- Misses      1859    1870   +11     
Impacted Files Coverage Δ
minimalkv/__init__.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simonbohnen simonbohnen marked this pull request as ready for review January 20, 2023 09:58
@xhochy xhochy merged commit da8528e into data-engineering-collective:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants