Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Airlock-friendly build dependencies #1135

Merged
merged 1 commit into from
Jan 9, 2025
Merged

ci: Airlock-friendly build dependencies #1135

merged 1 commit into from
Jan 9, 2025

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jan 9, 2025 •
edited
Loading

Airlock needs newer version of the Maven plugins. We also do not need to declare nexus-staging-maven-plugin by default.

@suztomo suztomo requested review from a team as code owners January 9, 2025 00:31
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 9, 2025
@suztomo suztomo force-pushed the troubleshooting_maven branch from 88e00f2 to 52624a5 Compare January 9, 2025 00:32
meltsufin
meltsufin approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use shared config as parent?

@suztomo suztomo merged commit b676657 into googleapis:main Jan 9, 2025
14 checks passed
@suztomo
Copy link
Member Author

suztomo commented Jan 9, 2025 •
edited
Loading

I tried that idea and in theory it should work but it became messy (#1133 (comment))

@suztomo suztomo mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suztomo @meltsufin