Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add OpenCensus integration #545

Merged
merged 6 commits into from
Dec 28, 2018
Merged

Re-add OpenCensus integration #545

merged 6 commits into from
Dec 28, 2018

Conversation

chingor13
Copy link
Collaborator

Fixes #459

@chingor13 chingor13 requested a review from a team as a code owner December 12, 2018 00:39
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2018
ajaaym
ajaaym reviewed Dec 12, 2018
View reviewed changes
google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java
@@ -883,7 +891,12 @@ public HttpResponse execute() throws IOException {
Preconditions.checkNotNull(requestMethod);
Preconditions.checkNotNull(url);

Span span = tracer
.spanBuilder(OpenCensusUtils.SPAN_NAME_HTTP_REQUEST_EXECUTE)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@ajaaym ajaaym changed the title Readd OpenCensus integration Read OpenCensus integration Dec 12, 2018
@chingor13 chingor13 changed the title Read OpenCensus integration Re-add OpenCensus integration Dec 12, 2018
@chingor13
Copy link
Collaborator Author

The title was correct, this was previously merged, and then reverted due to time crunch on integrating internally.

@bogdandrutu
Copy link

If possible avoid a high cardinality span name. If the URL does not have a high cardinality and it doesn't use any PII (like resource name) data then should be fine.

@bogdandrutu
Copy link

See this document https://github.com/census-instrumentation/opencensus-specs/blob/master/trace/HTTP.md

@chingor13 chingor13 mentioned this pull request Dec 13, 2018
Closed
@chingor13 chingor13 merged commit 6f89edc into googleapis:master Dec 28, 2018
@chingor13 chingor13 deleted the opencensus branch December 28, 2018 18:47
This was referenced Jan 3, 2019
Closed
Closed
Merged
elharo pushed a commit that referenced this pull request Mar 13, 2019
revert #545
e808917
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
@elharo
chore: revert back to correct license (BSD) (googleapis#545)
4ec16f9 
Automation accidentally changed this file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaaym ajaaym ajaaym left review comments

@bogdandrutu bogdandrutu bogdandrutu left review comments

@sduskis sduskis sduskis left review comments

@JesseLovelace JesseLovelace JesseLovelace approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chingor13 @bogdandrutu @sduskis @ajaaym @JesseLovelace @googlebot