Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guava is not provided #508

Merged
merged 1 commit into from
Nov 2, 2018
Merged

guava is not provided #508

merged 1 commit into from
Nov 2, 2018

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Oct 31, 2018 •
edited by chingor13
Loading

Fixes #502)

  • Tests pass
  • Appropriate docs were updated (if necessary)

There are some failing tests that don't seem related. Looking into those though:

Failed tests:

  HttpRequestTest.testExecute_curlLogger:1199 expected:<...P-Java-Client/1.26.0[-SNAPSHOT] (gzip)' -- 'http://...> but was:<...P-Java-Client/1.26.0[] (gzip)' -- 'http://...>
  HttpRequestTest.testExecute_curlLoggerWithContentEncoding:1230 expected:<...P-Java-Client/1.26.0[-SNAPSHOT] (gzip)' -H 'Content...> but was:<...P-Java-Client/1.26.0[] (gzip)' -H 'Content...>
  HttpRequestTest.testExecute_headerSerialization:961 expected:<[foo Google-HTTP-Java-Client/1.26.0-SNAPSHOT (gzip)]> but was:<[foo Google-HTTP-Java-Client/1.26.0 (gzip)]>
  HttpRequestTest.testSuppressUserAgentSuffix:1111 expected:<...P-Java-Client/1.26.0[-SNAPSHOT] (gzip)> but was:<...P-Java-Client/1.26.0[] (gzip)>
  HttpRequestTest.testUserAgentWithExecuteErrorAndIOExceptionHandler:630 expected:<...P-Java-Client/1.26.0[-SNAPSHOT] (gzip)> but was:<...P-Java-Client/1.26.0[] (gzip)>
  HttpRequestTest.testUserAgentWithExecuteErrorAndRetryEnabled:614 expected:<...P-Java-Client/1.26.0[-SNAPSHOT] (gzip)> but was:<...P-Java-Client/1.26.0[] (gzip)>

@elharo elharo requested a review from a team as a code owner October 31, 2018 11:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2018
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2018
@chingor13 chingor13 merged commit f4c4567 into googleapis:master Nov 2, 2018
chingor13 added a commit that referenced this pull request Nov 7, 2018
@chingor13
Revert "guava is not provided (#508)"
c23c313 
This reverts commit f4c4567.
@chingor13 chingor13 mentioned this pull request Nov 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update from 1.25.0 to 1.26.0 causes NoClassDefFoundError on 'Preconditions'
4 participants
@elharo @chingor13 @googlebot @kokoro-team