Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release improvements #501

Merged
merged 3 commits into from
Oct 29, 2018
Merged

Release improvements #501

merged 3 commits into from
Oct 29, 2018

Conversation

chingor13
Copy link
Collaborator

Fixes #499

  • actually enable the nexus-staging-maven-plugin
  • assembly.xml now renames the .jar.properties file with the current library version so we no longer have to rename the files during a release

@chingor13 chingor13 requested a review from a team as a code owner October 18, 2018 16:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2018
@chingor13 chingor13 requested a review from jeanbza October 18, 2018 16:46
jeanbza
jeanbza reviewed Oct 18, 2018
View reviewed changes
Copy link
Contributor

@jeanbza jeanbza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me, but I'm not really an expert on any of these plugins heh.

@chingor13 chingor13 merged commit d504e54 into googleapis:master Oct 29, 2018
@chingor13 chingor13 deleted the release-fixes branch October 29, 2018 16:21
@chingor13 chingor13 mentioned this pull request Nov 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbza jeanbza jeanbza left review comments

@elharo elharo elharo approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chingor13 @elharo @jeanbza @googlebot