-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix throwIfFalseEOF if skip method was called before read #447
Conversation
Can we add a test for this? It looks like we can add something like this:
|
Thanks for the test, added it to PR |
@medb Is it possible to rebase these changes off of the "dev" branch? Strangely, the "dev" branch is the primary branch, not "master" and the CI config in that branch cannot be run. |
throwIfFalseEOF method don't take into account bytes read/skipped in skip method and throws IOException when legit EOF was reached.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Rebased on |
CLAs look good, thanks! |
Thanks! |
This commit is to trigger automation for a new release. See googleapis#446 for actual change.
🤖 I have created a release \*beep\* \*boop\* --- ### [0.21.1](https://www.github.com/googleapis/google-auth-library-java/compare/v0.21.0...v0.21.1) (2020-07-07) ### Dependencies * update google-http-client to 1.36.0 ([googleapis#447](https://www.github.com/googleapis/google-auth-library-java/issues/447)) ([b913d19](https://www.github.com/googleapis/google-auth-library-java/commit/b913d194259e4f93bb401a844480f56b48dad3bd)), closes [googleapis#446](https://www.github.com/googleapis/google-auth-library-java/issues/446) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
throwIfFalseEOF method don't take into account bytes read/skipped in skip method and throws IOException when legit EOF was reached.