Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix arraymap iterator remove issue #371

Merged
merged 3 commits into from
Aug 28, 2018
Merged

fix arraymap iterator remove issue #371

merged 3 commits into from
Aug 28, 2018

Conversation

yantzu
Copy link
Contributor

@yantzu yantzu commented Sep 25, 2017

fix issue #370

@yantzu
Copy link
Contributor Author

yantzu commented Sep 25, 2017

Looks like Travis failed due to travis-ci/travis-ci#8199

Map.Entry<String,String> entry = iter.next();
if(!"all".equalsIgnoreCase(entry.getKey())){
iter.remove();
}

This comment was marked as spam.

This comment was marked as spam.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@yantzu
Copy link
Contributor Author

yantzu commented Mar 12, 2018

not sure what the googlebot want me to do. the code change committed by Matt is already in main git repository, right?

@lesv
Copy link
Contributor

lesv commented Mar 14, 2018

I'm going to close this as it appears to already be in the git repo.

I did verify that the CLA is correct.

@lesv lesv closed this Mar 14, 2018
mattwhisenhunt added a commit to mattwhisenhunt/google-http-java-client that referenced this pull request Mar 15, 2018
@yantzu
Copy link
Contributor Author

yantzu commented Mar 19, 2018

Hmmm..., I doesn't see my code in git repo dev branch

@lesv
Copy link
Contributor

lesv commented Mar 20, 2018

Yep. Someone else is going to take over the maint of this repo when he returns next week. I'll go over with him all the open PR's.

Apologies for the delay.

@lesv lesv reopened this Mar 20, 2018
@chingor13
Copy link
Collaborator

The CLA was signed by the commit author.

@chingor13 chingor13 merged commit c0a2f6d into googleapis:dev Aug 28, 2018
This was referenced Oct 12, 2018
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants