-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix arraymap iterator remove issue #371
Conversation
Looks like Travis failed due to travis-ci/travis-ci#8199 |
Map.Entry<String,String> entry = iter.next(); | ||
if(!"all".equalsIgnoreCase(entry.getKey())){ | ||
iter.remove(); | ||
} |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
not sure what the googlebot want me to do. the code change committed by Matt is already in main git repository, right? |
I'm going to close this as it appears to already be in the git repo. I did verify that the CLA is correct. |
Hmmm..., I doesn't see my code in git repo dev branch |
Yep. Someone else is going to take over the maint of this repo when he returns next week. I'll go over with him all the open PR's. Apologies for the delay. |
The CLA was signed by the commit author. |
Originally proposed in googleapis#371
fix issue #370