Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum-Array/Collection fails to serialize to XML String #504

Closed
geri-m opened this issue Oct 28, 2018 · 0 comments
Closed

Enum-Array/Collection fails to serialize to XML String #504

geri-m opened this issue Oct 28, 2018 · 0 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@geri-m
Copy link
Contributor

geri-m commented Oct 28, 2018

The implementation in #475 has a bug in that way, that Arrays/Collections of Enums fail to serialize, as the DataMap explicitly excluded Enums (Preconditions.checkArgument(!classInfo.isEnum());)

geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 28, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 28, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 28, 2018
@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Oct 29, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 29, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 29, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 29, 2018
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 30, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Oct 30, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 31, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 31, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 31, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 31, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 31, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Nov 2, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Nov 2, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Nov 2, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Nov 2, 2018
* issue-504:
  Change method of asserting enums (googleapis#504)
  Improve JavaDoc of Tests (googleapis#504)
  delete commented out code (googleapis#504)
  Use Guava for reading resource file (googleapis#504)
  Replace Heise feed with Custom feed, set encoding for reading file (googleapis#504)
  Try-with-resources Java6 Style (googleapis#504)
  Adding asserts in GenericXmlTests (googleapis#504)
  Cleanup documentation of tests (googleapis#504)
  Add more list tests (googleapis#504)
  Adding more Tests for XML parsing/mapping (googleapis#504)
  Fixes bug in googleapis#475, add relevant Tests (googleapis#504)
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Nov 6, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Nov 6, 2018
chingor13 pushed a commit that referenced this issue Nov 6, 2018
* Fixes bug in #475, add relevant Tests (#504)

* Adding more Tests for XML parsing/mapping (#504)

* Add more list tests (#504)

* Cleanup documentation of tests (#504)

* Adding asserts in GenericXmlTests (#504)

* Try-with-resources Java6 Style (#504)

* Replace Heise feed with Custom feed, set encoding for reading file (#504)

* Use Guava for reading resource file (#504)

* delete commented out code (#504)

* Improve JavaDoc of Tests (#504)

* Change method of asserting enums (#504)

* Minor fixes in JavaDoc (#504)

* Rename Test methods (#504)

* Fix Typo in JavaDoc (#504)

* Remove irrelevant annotation, clean up test case (#504)

* Fix incorrect/missing annotations, improve instanceof annotations (#504)
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this issue Aug 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants