Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parseElementInternal(...) in XML.java #490

Closed
geri-m opened this issue Oct 11, 2018 · 2 comments
Closed

Refactor parseElementInternal(...) in XML.java #490

geri-m opened this issue Oct 11, 2018 · 2 comments
Assignees
@elharo
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@geri-m
Copy link
Contributor

geri-m commented Oct 11, 2018

In order to improve readability and extendability the method parseElementInternal(...) in XML.java needs some refactoring. This enables us to add additional feature later.

Before heading for a code change, more unit tests should be implemented.
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 11, 2018
@geri-m
Adding some comments (googleapis#490)
245eae8
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 11, 2018
@geri-m
Extend GenericXml Test (googleapis#490)
6541f2e
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 11, 2018
@geri-m
Add Test with nested GenericXml (googleapis#490)
e62eda5
@chingor13 chingor13 added the type: cleanup An internal cleanup or hygiene concern. label Oct 11, 2018
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 12, 2018
@geri-m
Validation of additional Generic Test (googleapis#490)
cfc1f2c
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 12, 2018
@geri-m
Add Test for Array with primitiveType (googleapis#490)
5619a49
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 12, 2018
@geri-m
Add Test for various corner cases (googleapis#490)
28ffefe
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 12, 2018
@geri-m
Adding Tests for Collections (googleapis#490)
83ed28e
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 12, 2018
@geri-m
Adding Tests for Array with Classes (googleapis#490)
982b4e4
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 13, 2018
@geri-m
Extracted Various Methods (googleapis#490)
39087e8
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 13, 2018
@geri-m
Adding Global XML-Depth Level for Analysis (googleapis#490)
e26d17a
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 13, 2018
@geri-m
Implement global depth counter (googleapis#490)
4588bcb
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 14, 2018
@geri-m
Adding Tests for Custom Atom Parser (googleapis#490)
36c943d
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 14, 2018
@geri-m
Revert Xml.java to fix Atom Tests (googleapis#490)
c1b1a00
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 14, 2018
@geri-m
Adding XML Basic Tests with missing/additional Field (googleapis#490)
606717a
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 14, 2018
@geri-m
Update Atom Tests, fix Checkstyles (googleapis#490)
a12b274
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 15, 2018
@geri-m
Fix Atom Test with Read from File (googleapis#490)
30bb523
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 18, 2018
@geri-m
Add Documentation to Atom Tests (googleapis#490)
6ac8efc
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 18, 2018
@geri-m
Create ParserParamter Object (googleapis#490)
5884628
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 18, 2018
@geri-m
Adding Object for Return Value (googleapis#490)
1dfc068
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 18, 2018
@geri-m
Refactoring (googleapis#490)
50abe8c
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 20, 2018
@geri-m
Refactoring (googleapis#490)
d6c4b34
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 20, 2018
@geri-m
Add negative Tests (googleapis#490)
a73c9f1
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 20, 2018
@geri-m
Add Generic Simple Tests (googleapis#490)
2f1efe9
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 20, 2018
@geri-m
Adding Infinity Value Test (googleapis#490)
7f38889
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 20, 2018
@geri-m
Merge Commit (googleapis#490)
7132943
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 20, 2018
@geri-m
Add Array/Collection Type Tests with and w/o GenericType (googleapis#490
09d44ec 
)
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 20, 2018
@geri-m
Refactoring (googleapis#490)
e898d21
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 20, 2018
@geri-m
Add Tests for Empty Elements (googleapis#490)
46f0572
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 20, 2018
@geri-m
Separating Methods for different Parsers (googleapis#490)
4206b91
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 24, 2018
@geri-m
Reduction of parseAttributeOrTextContent (googleapis#490)
6a3ccc3
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 24, 2018
@geri-m
Refactoring and add some sanity checks (googleapis#490)
e3e34c8
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 24, 2018
@geri-m
Refactoring Dedicated Parser (googleapis#490)
fbb7e82
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 24, 2018
@geri-m
Refactoring (googleapis#490)
c8dde7a
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 24, 2018
@geri-m
Reduce parseAttributeOrTextContent (googleapis#490)
11bb3ca
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 24, 2018
@geri-m
Abstract setValue (googleapis#490)
c3878a7
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 25, 2018
@geri-m
Remove GenericXml from Abstract Impl (googleapis#490)
e78bf36
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 25, 2018
@geri-m
Extract mapCollection (googleapis#490)
47fbbf2
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 25, 2018
@geri-m
Extract mapArrayWithClassType (googleapis#490)
ed6fc22
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 26, 2018
@geri-m
Add test, add test docu, restructure test (googleapis#490)
31aab8e
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 26, 2018
@geri-m
Update on Generic Tests (googleapis#490)
9eac358
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 27, 2018
@geri-m
Add Generic List Tests (googleapis#490)
a6c415b
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 27, 2018
@geri-m
Add Generic List Tests (googleapis#490)
34ec724
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 27, 2018
@geri-m
Move destination Map to Parser from Main Loop (googleapis#490)
d3d0b73
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 27, 2018
@geri-m
abstract mapAsClassOrObjectType (googleapis#490)
2a711f2
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 27, 2018
@geri-m
Refactoring (googleapis#490)
e181f3b
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 27, 2018
@geri-m
Refactoring (googleapis#490)
f5c3b91
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 27, 2018
@geri-m
Fix Bug for GenericTests (googleapis#490)
51f6198
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Oct 27, 2018
@geri-m
Hot Fix for AtomTests (googleapis#490)
796b83a
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Nov 2, 2018
@geri-m
Rearrange Conditions to init objects (googleapis#490)
17031ba
geri-m added a commit to geri-m/google-http-java-client that referenced this issue Nov 4, 2018
@geri-m
Add Additional Test Cases (googleapis#490)
edfafab
@elharo
Copy link
Contributor

elharo commented Mar 15, 2020

Is this still in progress or done?

@geri-m
Copy link
Contributor Author

geri-m commented Mar 17, 2020

@elharo I was unable to complete this ticket, as the complexity of the code given was too high. happy to close the ticket and mark the refactoring as unresolved.

@elharo elharo closed this as completed Mar 17, 2020
yoshi-automation added a commit that referenced this issue Apr 14, 2020
@yoshi-automation
ci: add dependency list completeness check (#490)
09516a9 
Source-Author: Stephanie Wang <[email protected]>
Source-Date: Mon Apr 13 18:30:27 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 3df869dd6eb546ef13beeb7a9efa6ee0226afafd
Source-Link: googleapis/synthtool@3df869d
yoshi-automation added a commit that referenced this issue Apr 22, 2020
@yoshi-automation
ci: add dependency list completeness check (#490)
4e80290 
Source-Author: Stephanie Wang <[email protected]>
Source-Date: Mon Apr 13 18:30:27 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 3df869dd6eb546ef13beeb7a9efa6ee0226afafd
Source-Link: googleapis/synthtool@3df869d
yoshi-automation added a commit that referenced this issue Apr 25, 2020
@yoshi-automation
ci: add dependency list completeness check (#490)
955db79 
Source-Author: Stephanie Wang <[email protected]>
Source-Date: Mon Apr 13 18:30:27 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 3df869dd6eb546ef13beeb7a9efa6ee0226afafd
Source-Link: googleapis/synthtool@3df869d
chingor13 pushed a commit that referenced this issue Apr 27, 2020
@yoshi-automation
chore: update common templates (#1035)
1624d55 
* changes without context

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.

* ci: add dependency list completeness check (#490)

Source-Author: Stephanie Wang <[email protected]>
Source-Date: Mon Apr 13 18:30:27 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 3df869dd6eb546ef13beeb7a9efa6ee0226afafd
Source-Link: googleapis/synthtool@3df869d

* build(java): set GOOGLE_CLOUD_PROJECT env for samples/integration tests (#484)

* build(java): set GOOGLE_CLOUD_PROJECT env variable for samples/integration tests

* ci: use java-docs-samples-testing for sample tests

Source-Author: Jeff Ching <[email protected]>
Source-Date: Mon Apr 13 16:24:21 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 52638600f387deb98efb5f9c85fec39e82aa9052
Source-Link: googleapis/synthtool@5263860
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this issue Aug 11, 2022
@shinfan
fix: remove 1 hour limit for impersonated token (googleapis#490)
927e3d5 
Cloud IAM now supports extended 12h lifespan for access token.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elharo elharo

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chingor13 @elharo @geri-m