Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): Add Job#parent_job_id and Job#script_statistics #4926

Merged
merged 5 commits into from
Mar 30, 2020
Merged

feat(bigquery): Add Job#parent_job_id and Job#script_statistics #4926

merged 5 commits into from
Mar 30, 2020

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Mar 10, 2020 •
edited
Loading

  • Add Job#num_child_jobs
  • Add Job#parent_job_id
  • Add parent_job to Project#jobs
  • Add Job#script_statistics

closes: #4810

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2020
@quartzmo quartzmo self-assigned this Mar 10, 2020
@quartzmo quartzmo added api: bigquery Issues related to the BigQuery API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 10, 2020
@quartzmo quartzmo changed the title feat(bigquery): Add parent_job_id to Project#jobs feat(bigquery): Add Job#parent_job_id and Job#script_statistics Mar 27, 2020
@quartzmo quartzmo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 27, 2020
@quartzmo
Copy link
Member Author

@shollyman PTAL when you have time, thank you.

shollyman
shollyman approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

google-cloud-bigquery/acceptance/bigquery/advanced_test.rb Outdated Show resolved Hide resolved
@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 30, 2020
@TheRoyalTnetennba TheRoyalTnetennba added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@quartzmo quartzmo merged commit b473372 into googleapis:master Mar 30, 2020
@quartzmo quartzmo deleted the bigquery-scripting branch March 30, 2020 22:18
yoshi-automation added a commit that referenced this pull request Mar 31, 2020
@yoshi-automation
feat(bigquery): Add Job#parent_job_id and Job#script_statistics
3c254b9 
b473372
commit b473372
Author: Chris Smith <[email protected]>
Date:   Mon Mar 30 16:17:56 2020 -0600

    feat(bigquery): Add Job#parent_job_id and Job#script_statistics

    * Add parent_job to Project#jobs
    * Add Job#num_child_jobs
    * Add Job#parent_job_id
    * Add Job#script_statistics

    closes: #4810
    pr: #4926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@dazuma dazuma dazuma approved these changes

Assignees

@quartzmo quartzmo

Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: Ruby - Implement Scripting API Changes
6 participants
@quartzmo @dazuma @shollyman @googlebot @TheRoyalTnetennba @yoshi-kokoro