Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription name is not optional #740

Closed
Draiken opened this issue Jun 21, 2016 · 4 comments · Fixed by #1005
Closed

Subscription name is not optional #740

Draiken opened this issue Jun 21, 2016 · 4 comments · Fixed by #1005
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API.

Comments

@Draiken
Copy link

Draiken commented Jun 21, 2016

https://github.com/GoogleCloudPlatform/gcloud-ruby/blob/v0.11.0/lib/gcloud/pubsub/topic.rb#L94-L141

The example says we can leave out the name and get a generated name, but the method requires a name.

It's also not a good example, since we give name my-topic-sub and get name generated-sub-name

@Draiken
Copy link
Author

Draiken commented Jun 21, 2016

Nevermind... duplicate of #193

@Draiken Draiken closed this as completed Jun 21, 2016
@blowmage blowmage reopened this Jun 21, 2016
@blowmage
Copy link
Contributor

blowmage commented Jun 21, 2016

Hi @Draiken, thanks for opening this issue. We thought we had removed that example from the documentation when we discovered the discrepancy between the official API documentation and the API behavior. That is very confusing. I'm sorry for that. We will get the documentation updated.

@blowmage blowmage added docs api: pubsub Issues related to the Pub/Sub API. labels Jun 21, 2016
@blowmage
Copy link
Contributor

@quartzmo Can you make sure the documentation is correct?

@quartzmo
Copy link
Member

Yes, I'll look into it.

quartzmo added a commit to quartzmo/google-cloud-ruby that referenced this issue Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants