feat(core): add timeout param to JSONConnection.api_request() #9915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9914.
Towards #7831.
As discussed on a related PR, a "clients gets stuck" fix needs a timeout in the transport layer where the blockage randomly occurs occasionally.
Keeping the existing default behavior the same for now (
timeout=None
), but if there is a "good" default timeout value that suits all client libraries, we can make the requests timeout by default to avoid randomly blocking indefinitely.PR checklist