Replace connection in bucket constructor. #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This was referenced Jul 13, 2015
Towards googleapis#952, removing connection from methods / constructors.
Towards googleapis#952. Introduced temporary hack to allow system-tests to continue passing. Implicit environment has still not been completely removed.
dhermes
force-pushed
the
replace-connection-in-bucket
branch
from
8b1ecb2
to
017346a
Compare
| @@ -205,6 +205,6 @@ def get_items_from_response(self, response): | |||
| """ | |||
| for item in response.get('items', []): | |||
| name = item.get('name') | |||
| bucket = Bucket(name) | |||
| bucket = Bucket(None, name) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@tseaver Any remaining issues? |
| @@ -78,7 +78,7 @@ def set_default_bucket(bucket=None): | |||
| bucket_name = os.getenv(_BUCKET_ENV_VAR_NAME) | |||
|
|
|||
| if bucket_name is not None: | |||
| bucket = Bucket(bucket_name) | |||
| bucket = Bucket(None, name=bucket_name) | |||
|
|
|||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
We can merge this one to get to the next. |
dhermes
added a commit
that referenced
this pull request
Jul 20, 2015
Replace connection in bucket constructor.
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has #984 as diffbase.
Also updating storage.Batch to accept a client.
Introduced temporary hack to allow system-tests to continue passing. Implicit environment has still not been completely removed.