Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove '_implicit_environ' #979

Merged
merged 11 commits into from
Jul 13, 2015
Merged

Remove '_implicit_environ' #979

merged 11 commits into from
Jul 13, 2015

Commits on Jul 11, 2015

  1. Update batch/transaction/query to hold client. 

    Update batch/transaction to push themselves onto client's stack, rather
than batches.

Updated API-invoking methods to take 'client', rather than 'connection',
falling back to the client held by self.

See #944.
    @tseaver
    tseaver committed Jul 11, 2015
    1 Configuration menu
    Copy the full SHA
    ca42fdf View commit details
    Browse the repository at this point in the history

  2. Remove 'gcloud.datastore.set_defaults'. 

    Also remove symbols imported for conveniences from '_implicit_environ'.
    @tseaver
    tseaver committed Jul 11, 2015
    1 Configuration menu
    Copy the full SHA
    c16dae4 View commit details
    Browse the repository at this point in the history

  3. Remove implicit dataset ID lookup from key.

    @tseaver
    tseaver committed Jul 11, 2015
    1 Configuration menu
    Copy the full SHA
    94c9c11 View commit details
    Browse the repository at this point in the history

  4. Move dataset ID / connection discovery from '_implicit_environ' to 'c… 

    …lient'.
    @tseaver
    tseaver committed Jul 11, 2015
    2 Configuration menu
    Copy the full SHA
    dd99e2c View commit details
    Browse the repository at this point in the history

  5. Remove spurious implicit environ testing support.

    @tseaver
    tseaver committed Jul 11, 2015
    1 Configuration menu
    Copy the full SHA
    acde44c View commit details
    Browse the repository at this point in the history

  6. Remove '_implicit_environ' and testing support.

    @tseaver
    tseaver committed Jul 11, 2015
    1 Configuration menu
    Copy the full SHA
    f2c151a View commit details
    Browse the repository at this point in the history

  7. Update system tests to use client in place of '_implicit_envioron.'

    @tseaver
    tseaver committed Jul 11, 2015
    2 Configuration menu
    Copy the full SHA
    4a914db View commit details
    Browse the repository at this point in the history

  8. Undo odd rebase artefacts.

    @tseaver
    tseaver committed Jul 11, 2015
    1 Configuration menu
    Copy the full SHA
    1d9ca7d View commit details
    Browse the repository at this point in the history

  9. Fix coverage lapses induced by merge.

    @tseaver
    tseaver committed Jul 11, 2015
    1 Configuration menu
    Copy the full SHA
    e212d9b View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2015

  1. Nuke used-only-once '_get_connection'. 

    Addresses:
#979 (comment)
    @tseaver
    tseaver committed Jul 13, 2015
    Configuration menu
    Copy the full SHA
    1b0b19c View commit details
    Browse the repository at this point in the history

  2. Avoid shadowing 'client' module w/ 'Client' instance. 

    Addresses:
4a914db#commitcomment-12124183
    @tseaver
    tseaver committed Jul 13, 2015
    Configuration menu
    Copy the full SHA
    8423abd View commit details
    Browse the repository at this point in the history