Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): add support for hive partitioning options configuration #9626

Merged
merged 4 commits into from
Nov 19, 2019
Merged

feat(bigquery): add support for hive partitioning options configuration #9626

merged 4 commits into from
Nov 19, 2019

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Nov 7, 2019

Fixes #9610.

This PR adds support for configuring hive partitioning to LoadJobConfig and ExternalConfig classes.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: bigquery Issues related to the BigQuery API. labels Nov 7, 2019
@plamut plamut requested a review from a team November 7, 2019 08:45
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 7, 2019
@plamut plamut changed the title feat(bigquery): add support hive partitioning options configuration feat(bigquery): add support for hive partitioning options configuration Nov 7, 2019
@plamut
Copy link
Contributor Author

plamut commented Nov 7, 2019

The internal server error that makes the undelete table snippet test fail does not seem to be related, happens on the master branch as well. We should re-run the test suite again in a few hours.

@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2019
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019
@plamut plamut requested a review from tswast November 13, 2019 07:32
@plamut plamut mentioned this pull request Nov 18, 2019
Closed
tswast
tswast approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see a system test for this, too, but that's partially on me to make sure we have some public data we can use for that. I'll follow-up with a code sample for that once we have it.

@tswast tswast merged commit 15d4bb6 into googleapis:master Nov 19, 2019
@plamut plamut deleted the iss-9610 branch November 19, 2019 07:13
This was referenced Jan 29, 2020
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: Add support for configuring Hive partitioning options
4 participants
@plamut @tswast @googlebot @yoshi-kokoro