-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigquery): add --destination_table
parameter to bigquery magic
#9599
Conversation
@tswast could you take a look |
23d58db
to
043ede1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and seems to work as expected. 👍
I only have a few minor house-keeping comments.
--destination_table
parameter to bigquery magic
043ede1
to
037a761
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
Is Kokoro - Cloud Build failure a real issue or just a glitch? It doesn't return any logs. |
Cloud Build client is currently broken, so this failure is expected. |
As @tswast said - the Cloud Build is currently broken, and the failure is unrelated to this PR. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Sample use and test here: https://colab.research.google.com/drive/1vd_5IperzwBdqnzIPKd8fWkGZg4TO1Bb (google access only)
Fixes #9598
@sshrdp FYI