Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): add --destination_table parameter to bigquery magic #9599

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

vlasenkoalexey
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Sample use and test here: https://colab.research.google.com/drive/1vd_5IperzwBdqnzIPKd8fWkGZg4TO1Bb (google access only)

Fixes #9598
@sshrdp FYI

@vlasenkoalexey vlasenkoalexey requested a review from a team November 5, 2019 01:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 5, 2019
@vlasenkoalexey
Copy link
Contributor Author

@tswast could you take a look

Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and seems to work as expected. 👍

I only have a few minor house-keeping comments.

bigquery/google/cloud/bigquery/magics.py Outdated Show resolved Hide resolved
bigquery/google/cloud/bigquery/magics.py Outdated Show resolved Hide resolved
bigquery/google/cloud/bigquery/magics.py Outdated Show resolved Hide resolved
bigquery/tests/unit/test_magics.py Outdated Show resolved Hide resolved
@tseaver tseaver changed the title added --destination_table parameter to bigquery magic feat(bigquery): add --destination_table parameter to bigquery magic Nov 5, 2019
Copy link
Contributor Author

@vlasenkoalexey vlasenkoalexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR

@plamut plamut added the api: bigquery Issues related to the BigQuery API. label Nov 5, 2019
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@vlasenkoalexey
Copy link
Contributor Author

Is Kokoro - Cloud Build failure a real issue or just a glitch? It doesn't return any logs.

@tswast
Copy link
Contributor

tswast commented Nov 6, 2019

Cloud Build client is currently broken, so this failure is expected.

@plamut
Copy link
Contributor

plamut commented Nov 6, 2019

As @tswast said - the Cloud Build is currently broken, and the failure is unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: Add destination_table to %%bigquery magic to allow materializing query results
4 participants