Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move implicit majyk inside 'Client.__init__'. #956

Merged
merged 2 commits into from
Jul 2, 2015
Merged

Move implicit majyk inside 'Client.__init__'. #956

merged 2 commits into from
Jul 2, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 1, 2015

See #944.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2015
@tseaver tseaver mentioned this pull request Jul 1, 2015
Closed
8 tasks
@tseaver tseaver added the api: datastore Issues related to the Datastore API. label Jul 1, 2015
jgeewax
jgeewax reviewed Jul 1, 2015
View reviewed changes
gcloud/datastore/client.py
"""

def __init__(self, dataset_id, namespace=None, connection=None):
def __init__(self, dataset_id=None, connection=None, namespace=None):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Jul 1, 2015

This seems pretty straightforward, thanks for making the change tiny and digestible :)

LGTM other than the comments I've already made.

tseaver added a commit that referenced this pull request Jul 2, 2015
@tseaver
Merge pull request #956 from tseaver/944-client_ctor_defaults
b840232 
Move implicit majyk inside 'Client.__init__'.
@tseaver tseaver merged commit b840232 into googleapis:master Jul 2, 2015
@tseaver tseaver deleted the 944-client_ctor_defaults branch July 2, 2015 15:51
@dhermes dhermes mentioned this pull request Jul 10, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @jgeewax @googlebot