-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigquery): add Dataset.default_partition_expiration_ms and Table.require_partition_filter properties #9464
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
bigquery/samples/tests/test_update_dataset_default_partition_expiration.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# Copyright 2019 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from .. import update_dataset_default_partition_expiration | ||
|
||
|
||
def test_update_dataset_default_partition_expiration(capsys, client, dataset_id): | ||
|
||
ninety_days_ms = 90 * 24 * 60 * 60 * 1000 # in milliseconds | ||
|
||
update_dataset_default_partition_expiration.update_dataset_default_partition_expiration( | ||
client, dataset_id | ||
) | ||
out, _ = capsys.readouterr() | ||
assert ( | ||
"Updated dataset {} with new default partition expiration {}".format( | ||
dataset_id, ninety_days_ms | ||
) | ||
in out | ||
) |
33 changes: 33 additions & 0 deletions
33
bigquery/samples/tests/test_update_table_require_partition_filter.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# Copyright 2019 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from google.cloud import bigquery | ||
from .. import update_table_require_partition_filter | ||
|
||
|
||
def test_update_table_require_partition_filter(capsys, client, random_table_id): | ||
# Make a partitioned table. | ||
schema = [bigquery.SchemaField("transaction_timestamp", "TIMESTAMP")] | ||
table = bigquery.Table(random_table_id, schema) | ||
table.time_partitioning = bigquery.TimePartitioning(field="transaction_timestamp") | ||
table = client.create_table(table) | ||
|
||
update_table_require_partition_filter.update_table_require_partition_filter( | ||
client, random_table_id | ||
) | ||
out, _ = capsys.readouterr() | ||
assert ( | ||
"Updated table '{}' with require_partition_filter=True".format(random_table_id) | ||
in out | ||
) |
43 changes: 43 additions & 0 deletions
43
bigquery/samples/update_dataset_default_partition_expiration.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# Copyright 2019 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
|
||
def update_dataset_default_partition_expiration(client, dataset_id): | ||
|
||
# [START bigquery_update_dataset_partition_expiration] | ||
# TODO(developer): Import the client library. | ||
# from google.cloud import bigquery | ||
|
||
# TODO(developer): Construct a BigQuery client object. | ||
# client = bigquery.Client() | ||
|
||
# TODO(developer): Set dataset_id to the ID of the dataset to fetch. | ||
# dataset_id = 'your-project.your_dataset' | ||
|
||
dataset = client.get_dataset(dataset_id) # Make an API request. | ||
|
||
# Set the default partition expiration (applies to new tables, only) in | ||
# milliseconds. This example sets the default expiration to 90 days. | ||
dataset.default_partition_expiration_ms = 90 * 24 * 60 * 60 * 1000 | ||
|
||
dataset = client.update_dataset( | ||
dataset, ["default_partition_expiration_ms"] | ||
) # Make an API request. | ||
|
||
print( | ||
"Updated dataset {}.{} with new default partition expiration {}".format( | ||
dataset.project, dataset.dataset_id, dataset.default_partition_expiration_ms | ||
) | ||
) | ||
# [END bigquery_update_dataset_partition_expiration] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# Copyright 2019 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
|
||
def update_table_require_partition_filter(client, table_id): | ||
|
||
# [START bigquery_update_table_require_partition_filter] | ||
# TODO(developer): Import the client library. | ||
# from google.cloud import bigquery | ||
|
||
# TODO(developer): Construct a BigQuery client object. | ||
# client = bigquery.Client() | ||
|
||
# TODO(developer): Set table_id to the ID of the model to fetch. | ||
# table_id = 'your-project.your_dataset.your_table' | ||
|
||
table = client.get_table(table_id) # Make an API request. | ||
table.require_partition_filter = True | ||
table = client.update_table(table, ["require_partition_filter"]) | ||
|
||
# View table properties | ||
print( | ||
"Updated table '{}.{}.{}' with require_partition_filter={}.".format( | ||
table.project, | ||
table.dataset_id, | ||
table.table_id, | ||
table.require_partition_filter, | ||
) | ||
) | ||
# [END bigquery_update_table_require_partition_filter] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any annotations we can/should add to help docs/and existing consumers to understand this is no longer the preferred mechanism?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Added deprecation warning message in 84e2c3c