Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(bigquery): simplify scripting system test to reduce flakiness #9458

Merged
merged 1 commit into from
Oct 14, 2019
Merged

test(bigquery): simplify scripting system test to reduce flakiness #9458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 7 additions & 24 deletions bigquery/tests/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ def test_list_tables(self):
self.assertGreater(len(list(iterator)), 0)

def test_listing_scripting_jobs(self):
# run an SQL script
# Run a SQL script.
sql_script = """
-- Declare a variable to hold names as an array.
DECLARE top_names ARRAY<STRING>;
Expand All @@ -453,31 +453,14 @@ def test_listing_scripting_jobs(self):
FROM `bigquery-public-data.samples.shakespeare`
);
"""
test_start = datetime.datetime.utcnow()
query_job = Config.CLIENT.query(sql_script, project=Config.CLIENT.project)
query_job.result()

# fetch jobs created by the SQL script, sort them into parent and
# child jobs
script_jobs = list(Config.CLIENT.list_jobs(min_creation_time=test_start))

parent_jobs = []
child_jobs = []
parent_job = Config.CLIENT.query(sql_script, project=Config.CLIENT.project)
parent_job.result()

for job in script_jobs:
if job.num_child_jobs > 0:
parent_jobs.append(job)
else:
child_jobs.append(job)

assert len(parent_jobs) == 1 # also implying num_child_jobs > 0
assert len(child_jobs) == parent_jobs[0].num_child_jobs
# Fetch jobs created by the SQL script.
child_jobs = list(Config.CLIENT.list_jobs(parent_job=parent_job))

# fetch jobs using the parent job filter, verify that results are as expected
fetched_jobs = list(Config.CLIENT.list_jobs(parent_job=parent_jobs[0]))
assert sorted(job.job_id for job in fetched_jobs) == sorted(
job.job_id for job in child_jobs
)
assert parent_job.num_child_jobs > 0
assert len(child_jobs) == parent_job.num_child_jobs

def test_update_table(self):
dataset = self.temp_dataset(_make_dataset_id("update_table"))
Expand Down