fix(storage): enable CSEK w/ V4 signed URLs #9450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
frankyn
reviewed
Oct 10, 2019
| @@ -468,6 +468,11 @@ def generate_signed_url( | |||
| else: | |||
| helper = generate_signed_url_v4 | |||
|
|
|||
| if self._encryption_key is not None: | |||
There was a problem hiding this comment.
this should only be done if v4.
There was a problem hiding this comment.
Per chat, we still need to add the X-Goog-Encryption-Algorithm header for V2 (but not the key or hash, oddly enough). See: https://cloud.google.com/storage/docs/access-control/signed-urls-v2#about-canonical-extension-headers
Only the 'X-Goog-Encryption-Algorithm' gets added to the signed headers. Ugh.
frankyn
approved these changes
Oct 10, 2019
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7626