Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storage): clarify docstring for 'Blob.download_as_string' #9332

Merged
merged 3 commits into from
Sep 27, 2019
Merged

docs(storage): clarify docstring for 'Blob.download_as_string' #9332

merged 3 commits into from
Sep 27, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 27, 2019

Specify that the returned value is bytes in the summary, and note the
historical reason for the confused method name.

Closes #9290.

Specify that the returned value is bytes in the summary, and note the
historical reason for the confused method name.

Closes #9290.
@tseaver tseaver added the type: docs Improvement to the documentation for an API. label Sep 27, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2019
storage/google/cloud/storage/blob.py Outdated Show resolved Hide resolved
@tseaver tseaver merged commit 20ebf60 into googleapis:master Sep 27, 2019
@tseaver tseaver deleted the 9290-storage-fix-blob-download_as_string-docstring branch September 27, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage: download_as_string documentation says that it downloads a string, instead of bytes
3 participants