Spanner: Fix run_in_transaction
return value docs
#9264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These docs used to be correct, but
Session.run_in_transaction
waschanged from returning the commit timestamp to returning the function
value in #3753, and the upstream docs were not updated.
The docs for
run_in_transaction
are now identical acrossDatabase
and
Session
.The tests for
run_in_transaction
(intest_database.py
) are wrong, asthey mock out the session object instead of using a real session, and
they also were not updated in #3753. This change does not fix them.
Test Plan:
wchargin-branch: run-in-transaction-rval