Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: HMAC add user_project param #9237

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Storage: HMAC add user_project param #9237

merged 3 commits into from
Sep 25, 2019

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Sep 17, 2019

fixes #9236

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2019
frankyn
frankyn approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@frankyn
Copy link
Member

frankyn commented Sep 25, 2019 •
edited
Loading

@tseaver could you review and approve if LGTY? (I don't have permission to merge PRs).

@tseaver tseaver merged commit d8ce06e into master Sep 25, 2019
@tseaver tseaver deleted the hmac-user-project branch September 25, 2019 19:17
@jkwlui
Copy link
Member Author

jkwlui commented Sep 25, 2019

@tseaver Can you help cut a release so we get this fix out? Thanks!

@tseaver
Copy link
Contributor

tseaver commented Sep 26, 2019

@jkwlui release PR pending: #9319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage: hmac operations should support userProject
4 participants
@jkwlui @frankyn @tseaver @googlebot