-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery: Disable failing snippets test #9156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_copy_table_cmek() results in internal error on the backend, causing the test to fail, thus the test is marked as skipped.
plamut
added
api: bigquery
Issues related to the BigQuery API.
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
labels
Sep 2, 2019
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 2, 2019
tswast
approved these changes
Sep 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Backend team needs to rollout a release with the fix, which is on the order of a week or two. We can re-enable the test once the backend is fixed.
tswast
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Sep 2, 2019
For Googlers investigating this issue, it's internal bug 140294699 with the reported CMEK failures. |
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 11, 2019
test_copy_table_cmek() results in internal error on the backend, causing the test to fail, thus the test is marked as skipped.
plamut
pushed a commit
that referenced
this pull request
Sep 12, 2019
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
test_copy_table_cmek() results in internal error on the backend, causing the test to fail, thus the test is marked as skipped.
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the BigQuery API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_copy_table_cmek()
snippets test results in internal error on the backend and fails, blocking the PRs, and this PR marks the test as skipped.Currently awaiting more information from the backend team. If the issue is not fixed soon, we will temporarily disable the test, but until then please do not merge this PR just yet.