Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Treat NaN as NULL when converting from pandas to arrow. #8785

Merged
merged 2 commits into from
Jul 25, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jul 25, 2019

Fixes broken unit tests from latest pyarrow release.

Fixes broken unit tests from latest pyarrow release.
@tswast tswast requested review from tseaver and a team July 25, 2019 21:15
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2019
@tswast tswast changed the title Treat NaN as NULL when converting from pandas to arrow. BigQuery: Treat NaN as NULL when converting from pandas to arrow. Jul 25, 2019
@tswast tswast added api: bigquery Issues related to the BigQuery API. type: process A process-related concern. May include testing, release, or the like. labels Jul 25, 2019
@tseaver
Copy link
Contributor

tseaver commented Jul 25, 2019

Do we need a minimum version of PyArrow to account for the new behavior?

Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the info from the link, the change looks good.

@tswast
Copy link
Contributor Author

tswast commented Jul 25, 2019

Do we need a minimum version of PyArrow to account for the new behavior?

The new behavior is present in 0.14.0 and later. I don't really have a strong opinion one way or the other on how NaN values are handled, so I'm hesitant to restrict the pyarrow version in setup.py.

@tswast tswast merged commit 26d90ab into googleapis:master Jul 25, 2019
@tswast tswast deleted the pyarrow branch July 25, 2019 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants