Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding passenv to tox.ini. #875

Merged
merged 1 commit into from
May 13, 2015
Merged

Adding passenv to tox.ini. #875

merged 1 commit into from
May 13, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented May 13, 2015

Just a test PR for #874

Fixes #874. As of tox 2.0, no environment variables are passed through by default.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2015
@dhermes dhermes changed the title Foo Adding passenv to tox.ini. May 13, 2015
@dhermes
Copy link
Contributor Author

dhermes commented May 13, 2015

@tseaver I made this PR actually valuable.

PTAL

@dhermes
Copy link
Contributor Author

dhermes commented May 13, 2015

I only covered regression tests, turns out I needed to cover lint and docs too.

@dhermes
Adding passenv to tox.ini.
bb4e4df 
Fixes googleapis#874. As of tox 2.0, no environment variables are
passed through by default.
@dhermes
Copy link
Contributor Author

dhermes commented May 13, 2015

Scratch that, docs didn't need it, scripts/merge.sh runs scripts/update_docs.sh but not via tox. I did update the original commit to also include lint though.

@tseaver
Copy link
Contributor

tseaver commented May 13, 2015

LGTM

@tseaver tseaver mentioned this pull request May 13, 2015
Closed
dhermes added a commit that referenced this pull request May 13, 2015
@dhermes
Merge pull request #875 from dhermes/fix-874
a7922c4 
Adding passenv to tox.ini.
@dhermes dhermes merged commit a7922c4 into googleapis:master May 13, 2015
@dhermes dhermes deleted the fix-874 branch May 13, 2015 20:29
@dhermes dhermes mentioned this pull request May 14, 2015
Merged
@dhermes dhermes mentioned this pull request Jun 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Travis regression tests are being run when they shouldn't be
3 participants
@dhermes @tseaver @googlebot