BigQuery Storage: Update quickstart sample with data format and sharding options. #8665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tswast
added
the
api: bigquerystorage
|
Comments copied from @shollyman's GoogleCloudPlatform/golang-samples#906. |
shollyman
approved these changes
Jul 12, 2019
tseaver
changed the title
tseaver
reviewed
Jul 12, 2019
| *_pb2_grpc.py | ||
| google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py | ||
| google/cloud/bigquery_storage_v1beta1/gapic/transports/big_query_storage_grpc_transport.py | ||
| tests/unit/gapic/v1beta1/test_big_query_storage_client_v1beta1.py |
There was a problem hiding this comment.
Is this change intentional? Seems like it might break stuff.
There was a problem hiding this comment.
Linter is passing. Seems these lines are no longer needed.
| # Add templated files | ||
| # ---------------------------------------------------------------------------- | ||
| templated_files = common.py_library(unit_cov_level=79, cov_level=79, samples_test=True, system_test_dependencies=["fastavro", "pandas", "pyarrow != 0.14.0"]) | ||
| s.move(templated_files) |
There was a problem hiding this comment.
Might need one or more excludes here.
There was a problem hiding this comment.
I'd rather keep the common templates if possible. It seems to be working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
samples/directory.synth.pyto use common templates (which now includes samples tests in the noxfile).