-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#825: Allow passing explicit connection to ACL.{reload,save}
#853
#825: Allow passing explicit connection to ACL.{reload,save}
#853
Conversation
Use new 'connection', 'reload_path', and 'save_path' properties to make the base class implementation generic.
Changes Unknown when pulling 0ed115b on tseaver:825-storage_acl-explicit_connection into * on GoogleCloudPlatform:master*. |
"""Reload the ACL data from Cloud Storage. | ||
@property | ||
def connection(self): | ||
"""Compute the connection for API requests for this ACL. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@dhermes PTAL |
""" | ||
# Allow override for testing | ||
path = getattr(self, '_reload_path', None) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
LGTM. @tseaver I'd like to have a pow-wow about the current state of our ACL support and try to figure out what we want (or better yet, what someone wants that's actually used ACLs for an application). Things are a bit out of place in the current state (e.g. |
#825: Allow passing explicit connection to `ACL.{reload,save}`
It is annyoing that those docs can't keep role vs. permisison straight, even on the same page. If |
We should also work out how to support the predefined ACLs feature |
See #825